Skip to content

Fix actions padding for M3 alert dialogs #105008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 12 commits into from
Jun 1, 2022
Merged

Fix actions padding for M3 alert dialogs #105008

guidezpl merged 12 commits into from
Jun 1, 2022

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented May 31, 2022

Also did some cleanup on dialog_theme.dart

Before After
alert_before alert_after

Fixes #105007

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 31, 2022
guidezpl
guidezpl commented May 31, 2022
View reviewed changes
packages/flutter/lib/src/material/dialog.dart
///
/// * [OverflowBar], which [actions] configures to lay itself out.
final EdgeInsetsGeometry actionsPadding;
final EdgeInsetsGeometry? actionsPadding;
Copy link
Member Author

@guidezpl guidezpl May 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to add theming capabilities in the next PR

TahaTesser
TahaTesser approved these changes Jun 1, 2022
View reviewed changes
@guidezpl guidezpl merged commit 51b2c48 into flutter:master Jun 1, 2022
@guidezpl guidezpl deleted the dialogs-m3-fix branch June 1, 2022 08:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
84f5999 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
19f8264 
)
@guidezpl guidezpl mentioned this pull request Jun 1, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
393657b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
6b1f711 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
4ba2c0d 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
4a5c958 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
2c381d6 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
d84e4ab 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
7d68708 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
bbcaac8 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
0d3b4d2 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
3b4c119 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
fd13372 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
f16366d 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
892ae24 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
1e45acc 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
8bbc443 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
bf9bbbc 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
c033cee 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
eeb9e9c 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
52b6f14 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
08cc6c1 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
6c94b42 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
3100367 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
17adae1 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
435d9a6 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
669bcad 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
87d9654 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
2a2a960 
)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @TahaTesser @camsim99
Fix actions padding for M3 alert dialogs (flutter#105008)
a6e2631 
* update docs

* use correct actions padding for dialogs

* remove trailing spaces

* Update dialog_theme.dart

* Update packages/flutter/lib/src/material/dialog.dart

Co-authored-by: Taha Tesser <[email protected]>

Co-authored-by: Taha Tesser <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
70c14b5 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
51b2c48 Fix actions padding for M3 alert dialogs (flutter/flutter#105008
3d271be 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Alert dialog actions padding isn't right

2 participants

@guidezpl @TahaTesser