feat(tools): Arbitrary browser flags (closes #65575) #104935

Gustl22 · 2022-05-29T22:07:42Z

Description

Ability to set arbitrary browser flags.

Example usage:

flutter run -d chrome --web-browser-flag "--disable-web-security"
flutter drive --driver=test_driver/integration_test.dart --target=integration_test/app_test.dart -d web-server --web-browser-flag="--autoplay-policy=no-user-gesture-required"

Related issues

#65575

Change policies

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
I think there's no docs that need a migration guide, but we should adapt the WIKI

Notes

I could not test my changes in real use case as I get this error (on Windows Powershell):

 dart D:/Coding/git/flutter/flutter/packages/flutter_tools/bin/flutter_tools.dart drive --driver=test_driver/integration_test.dart           --target=integration_test/app_test.dart           -d web-server --browser-flags="--incognito"
Running "flutter pub get" in example...                            994ms
Launching integration_test/app_test.dart on Web Server in debug mode...
ERROR: FormatException: Could not find an option named "verbosity".

Usage: server [options] [input.dart]

If filename or uri pointing to the entrypoint is provided on the command line,
then the server compiles it, generates dill file and exits.
If no entrypoint is provided on the command line, server waits for
instructions from stdin.

Do you have a clue, how to execute the flutter tool command from source?

The unit tests seem to work fine.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Gustl22 · 2022-06-07T11:03:16Z

@jonahwilliams kindly asking for a review, if you have time?

jonahwilliams

I'm not sure what that errors is caused by exactly, but could be related to a webdriver version mismatch. I would make sure your webdriver version is newer.

Does run work with this new flag?

packages/flutter_tools/lib/src/commands/drive.dart

packages/flutter_tools/lib/src/drive/web_driver_service.dart

Gustl22 · 2022-06-09T09:14:16Z

I would make sure your webdriver version is newer.

I checked, Chromedriver version matches the Chrome version :/

Does run work with this new flag?

Same error for run

dart D:/Coding/git/flutter/flutter/packages/flutter_tools/bin/flutter_tools.dart run lib/main.dart -d web-server --web-browser-flags="--incognito"
Launching lib/main.dart on Web Server in debug mode...
ERROR: FormatException: Could not find an option named "verbosity".

Usage: server [options] [input.dart]

Also tried it on my Linux-PC, same error message for both commands. Do I miss something? Btw: it recognizes when I use a wrong a wrong option, so the new source code seems to be valid somehow.

Edit: I think I have to upgrade flutter to the master channel. Thought this is not necessary, as the tools should be executed from the sources, but not the dart command though...

christopherfujino · 2022-06-09T15:44:26Z

Edit: I think I have to upgrade flutter to the master channel. Thought this is not necessary, as the tools should be executed from the sources, but not the dart command though...

You should be testing your tool changes with the version of the Dart SDK in your Flutter commit. If you use the bin/flutter bash or bin/flutter.bat batch wrapper scripts, this will ensure you are using the correct version of Dart to compile and run the tool: https://github.com/flutter/flutter/blob/master/bin/flutter

Gustl22 · 2022-06-10T08:30:26Z

You should be testing your tool changes with the version of the Dart SDK in your Flutter commit.

Thanks worked now flawlessly:

D:/Coding/git/flutter/flutter/bin/dart.bat D:/Coding/git/flutter/flutter/packages/flutter_tools/bin/flutter_tools.dart run lib/main.dart -d chrome --web-browser-flags="--incognito"

D:/Coding/git/flutter/flutter/bin/dart.bat D:/Coding/git/flutter/flutter/packages/flutter_tools/bin/flutter_tools.dart drive --driver=test_driver/integration_test.dart --target=integration_test/app_test.dart -d web-server --browser-flags="--incognito --autoplay-policy=no-user-gesture-required" --no-headless

Gustl22 · 2022-06-16T12:11:22Z

Kindly remind you for continuing the review
@christopherfujino @jonahwilliams, if you can afford the time :)

packages/flutter_tools/lib/src/commands/drive.dart

packages/flutter_tools/lib/src/runner/flutter_command.dart

jonahwilliams

LGTM

jonahwilliams · 2022-06-16T19:04:48Z

Looks like flutter drive already has web-browser-flags? Can you de-duplicate that?

packages/flutter_tools/lib/src/commands/drive.dart

Gustl22 · 2022-06-23T09:06:38Z

@christopherfujino @jonahwilliams can you have a look again?
Btw: (Tests fail due to a svg pixel discrepancy, I doubt, that has anything to do with tooling)

christopherfujino · 2022-06-23T17:27:48Z

@christopherfujino @jonahwilliams can you have a look again? Btw: (Tests fail due to a svg pixel discrepancy, I doubt, that has anything to do with tooling)

Can you rebase upstream? I'm sure you didn't break the goldens with this change, but a) it could be obscuring other legitimate failures, and b) we can't merge this without green pre-submits anyway.

christopherfujino

Other than failing pre-submits (likely not related), LGTM

Gustl22 · 2022-06-24T10:24:33Z

@christopherfujino ok weird, the CI didn't like the merged, but rather rebased commits...

…/flutter#104935)

…104935)

…/flutter#104935)

aytunch · 2023-02-20T21:45:51Z

@Gustl22 How can we use these chrome flags in launch.json?
My current web launh config is as follows:

        {
            "name": "Web Flutter development",
            "cwd": "apps/web",
            "request": "launch",
            "type": "dart",
            "args": [
                "--flavor=development",
                "web-browser-flag=--disable-web-security"
            ]
        },

Gustl22 · 2023-02-20T21:58:51Z

I think like every other arg, too, by escaping the double quotes:

{
  ...
  "args": [
    "--flavor",
    "development",
    "--web-browser-flag",
    "\"--disable-web-security\""
  ]
}

or

{
  ...
  "args": [
    "--flavor=development",
    "--web-browser-flag=\"--disable-web-security\""
  ]
}

Let me know, if it's working.

aytunch · 2023-02-20T22:07:31Z

@Gustl22 yes it worked :)
did not even need the escape characters

            "args": [
                "--flavor=development",
                "--web-browser-flag=--disable-web-security"
            ]

Also, would this flag work in release version of our web apps as well?
Because now I see a warning in chrome:

When I use flutter build instead of flutter run, I can not give this flag anymore. So what should we do for our release apps?

Gustl22 · 2023-02-20T22:29:07Z

Also, would this flag work in release version of our web apps as well? Because now I see a warning in chrome.

No this is just for development and testing. Or more specifically the user (client) can decide if they want to disable this security "feature".

To make this working in production you have to enable CORS on your server.

balee · 2023-08-26T15:05:45Z

@Gustl22

Thank you for the cool feature!

This works: flutter run -d chrome --web-browser-flag "--disable-web-security"
This also works: "c:\Program Files\Google\Chrome\Application\chrome.exe" --user-data-dir=c:\tmp\somedir

However, this doesn't work (user data dir setting is not applied): flutter run -d chrome --web-browser-flag "--user-data-dir=c:\tmp\somedir"

Any thoughts?

Gustl22 · 2023-08-26T16:15:09Z

However, this doesn't work (user data dir setting is not applied): flutter run -d chrome --web-browser-flag "--user-data-dir=c:\tmp\somedir"

Any thoughts?

You may need to quote the path itself, too:

flutter run -d chrome --web-browser-flag "--user-data-dir=\"c:\tmp\somedir\""
# or
flutter run -d chrome --web-browser-flag=--user-data-dir="c:\tmp\somedir"

balee · 2023-08-26T18:30:26Z

Nope :(
I have just looked at the source and found out how chrome is called.
It turned out it tries %USER%\appdata\Local\Google\Chrome\Application\chrome.exe first.
I created an empty file here and tried to run flutter like above.

The error message:

Oops; flutter has exited unexpectedly: "ProcessException: %1 is not a valid Win32 application.

  Command: C:\Users\...\AppData\Local\Google\Chrome\Application\chrome.exe
  --user-data-dir=C:\Users\...\AppData\Local\Temp\flutter_tools.af219ae6\flutter_tools_chrome_device.e9222837
  --remote-debugging-port=64216 --disable-background-timer-throttling --disable-extensions --disable-popup-blocking
  --bwsi --no-first-run --no-default-browser-check --disable-default-apps --disable-translate
  --user-data-dir=c:\tmp\somedir http://localhost:64144".

You can see that there are two --user-data-dir params and it seems the first is taken into account by chrome :(

balee · 2023-08-26T19:23:42Z

The correct solution seems to be moving ...webBrowserFlags to the front of the list so that the default parameters could be overriden, see:

    final List<String> args = <String>[
      chromeExecutable,
      // Using a tmp directory ensures that a new instance of chrome launches
      // allowing for the remote debug port to be enabled.
      '--user-data-dir=${userDataDir.path}',
      '--remote-debugging-port=$port',
      // When the DevTools has focus we don't want to slow down the application.
      '--disable-background-timer-throttling',
      // Since we are using a temp profile, disable features that slow the
      // Chrome launch.
      '--disable-extensions',
      '--disable-popup-blocking',
      '--bwsi',
      '--no-first-run',
      '--no-default-browser-check',
      '--disable-default-apps',
      '--disable-translate',
      if (headless)
        ...<String>[
          '--headless',
          '--disable-gpu',
          '--no-sandbox',
          '--window-size=2400,1800',
        ],
      ...webBrowserFlags,
      url,
    ];

### Respect user-data-dir flag from web-browser-flag Currently, it's already possible to pass `web-browser-flag` when launching Chrome, but the `user-data-dir` flag doesn't work as expected, and there are some reasons for that. In the implementation made in [PR #104935](#104935), the `web-browser-flag` is appended at the end of the Chrome launch arguments. For most scenarios, this works fine, as demonstrated in the Chrome unit test below: https://source.chromium.org/chromium/chromium/src/+/main:base/command_line_unittest.cc ``` TEST(CommandLineTest, MultipleSameSwitch) { const CommandLine::CharType* argv[] = { FILE_PATH_LITERAL("program"), FILE_PATH_LITERAL("--foo=one"), // --foo first time FILE_PATH_LITERAL("-baz"), FILE_PATH_LITERAL("--foo=two") // --foo second time }; CommandLine cl(std::size(argv), argv); EXPECT_TRUE(cl.HasSwitch("foo")); EXPECT_TRUE(cl.HasSwitch("baz")); EXPECT_EQ("two", cl.GetSwitchValueASCII("foo")); } ``` In this scenario, the parser will consider the last occurrence of a flag. However, this behavior does not apply to certain flags, because Chrome processes some of them based on the first occurrence, not the last. This is the case for `--user-data-dir`, which is parsed very early during Chrome startup. The proposed code checks whether `--user-data-dir` was provided via `web-browser-flag`, and if so, it uses that value instead of the default `%temp%\flutter_tools_chrome_device.xpto` temporary directory. This also resolve this comment: #104935 (comment) Example: `launch.json` ``` { "version": "0.2.0", "configurations": [ { "name": "flutter", "request": "launch", "type": "dart" }, { "name": "flutter (profile mode)", "request": "launch", "type": "dart", "flutterMode": "profile" }, { "name": "flutter (release mode)", "request": "launch", "type": "dart", "flutterMode": "release" }, { "name": "Flutter for web (hot reloadable)", "type": "dart", "request": "launch", "program": "lib/main.dart", "args": [ "-d", "chrome", "--web-port=5000", "--web-experimental-hot-reload", "--web-browser-flag=--user-data-dir=D:\\_Desenv\\flutter_tests\\chrome_profile" ] } ] } ``` `chrome://version` | Before | After | |--------|--------| | ![before](https://github.com/user-attachments/assets/b3f33419-fbf1-446e-a471-745df2e8c4f6) | ![after](https://github.com/user-attachments/assets/ea74a203-c269-4ce1-8a9b-f97e9a4cdc78) | Folder | Before | After | |--------|--------| | ![before_files](https://github.com/user-attachments/assets/8522e60b-d0eb-4b66-a4b6-c2d6ed34c15b) | ![after_files](https://github.com/user-attachments/assets/ff94b498-b319-474c-89e5-c55f6e1c4383) | ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…#169445) ### Respect user-data-dir flag from web-browser-flag Currently, it's already possible to pass `web-browser-flag` when launching Chrome, but the `user-data-dir` flag doesn't work as expected, and there are some reasons for that. In the implementation made in [PR flutter#104935](flutter#104935), the `web-browser-flag` is appended at the end of the Chrome launch arguments. For most scenarios, this works fine, as demonstrated in the Chrome unit test below: https://source.chromium.org/chromium/chromium/src/+/main:base/command_line_unittest.cc ``` TEST(CommandLineTest, MultipleSameSwitch) { const CommandLine::CharType* argv[] = { FILE_PATH_LITERAL("program"), FILE_PATH_LITERAL("--foo=one"), // --foo first time FILE_PATH_LITERAL("-baz"), FILE_PATH_LITERAL("--foo=two") // --foo second time }; CommandLine cl(std::size(argv), argv); EXPECT_TRUE(cl.HasSwitch("foo")); EXPECT_TRUE(cl.HasSwitch("baz")); EXPECT_EQ("two", cl.GetSwitchValueASCII("foo")); } ``` In this scenario, the parser will consider the last occurrence of a flag. However, this behavior does not apply to certain flags, because Chrome processes some of them based on the first occurrence, not the last. This is the case for `--user-data-dir`, which is parsed very early during Chrome startup. The proposed code checks whether `--user-data-dir` was provided via `web-browser-flag`, and if so, it uses that value instead of the default `%temp%\flutter_tools_chrome_device.xpto` temporary directory. This also resolve this comment: flutter#104935 (comment) Example: `launch.json` ``` { "version": "0.2.0", "configurations": [ { "name": "flutter", "request": "launch", "type": "dart" }, { "name": "flutter (profile mode)", "request": "launch", "type": "dart", "flutterMode": "profile" }, { "name": "flutter (release mode)", "request": "launch", "type": "dart", "flutterMode": "release" }, { "name": "Flutter for web (hot reloadable)", "type": "dart", "request": "launch", "program": "lib/main.dart", "args": [ "-d", "chrome", "--web-port=5000", "--web-experimental-hot-reload", "--web-browser-flag=--user-data-dir=D:\\_Desenv\\flutter_tests\\chrome_profile" ] } ] } ``` `chrome://version` | Before | After | |--------|--------| | ![before](https://github.com/user-attachments/assets/b3f33419-fbf1-446e-a471-745df2e8c4f6) | ![after](https://github.com/user-attachments/assets/ea74a203-c269-4ce1-8a9b-f97e9a4cdc78) | Folder | Before | After | |--------|--------| | ![before_files](https://github.com/user-attachments/assets/8522e60b-d0eb-4b66-a4b6-c2d6ed34c15b) | ![after_files](https://github.com/user-attachments/assets/ff94b498-b319-474c-89e5-c55f6e1c4383) | ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 29, 2022

christopherfujino added the platform-web Web applications specifically label Jun 2, 2022

jonahwilliams reviewed Jun 7, 2022

View reviewed changes

packages/flutter_tools/lib/src/commands/drive.dart Outdated Show resolved Hide resolved

packages/flutter_tools/lib/src/drive/web_driver_service.dart Outdated Show resolved Hide resolved

jonahwilliams requested a review from christopherfujino June 7, 2022 13:46

jonahwilliams reviewed Jun 16, 2022

View reviewed changes

packages/flutter_tools/lib/src/commands/drive.dart Outdated Show resolved Hide resolved

jonahwilliams reviewed Jun 16, 2022

View reviewed changes

packages/flutter_tools/lib/src/runner/flutter_command.dart Outdated Show resolved Hide resolved

jonahwilliams approved these changes Jun 16, 2022

View reviewed changes

christopherfujino suggested changes Jun 16, 2022

View reviewed changes

packages/flutter_tools/lib/src/commands/drive.dart Outdated Show resolved Hide resolved

christopherfujino approved these changes Jun 23, 2022

View reviewed changes

feat(tools): Additional browser flags (closes flutter#65575)

f0e41dc

Gustl22 force-pushed the 65575-browser-arbitrary-arguments branch from 45e6343 to f0e41dc Compare June 24, 2022 09:28

christopherfujino added the waiting for tree to go green label Jun 24, 2022

fluttergithubbot merged commit 47f54ac into flutter:master Jun 24, 2022

Gustl22 deleted the 65575-browser-arbitrary-arguments branch June 24, 2022 18:27

This was referenced Jun 25, 2022

Roll Flutter from 6c3a0e4d21da to a0ef08dec4aa (12 revisions) flutter/plugins#6040

Closed

Roll Flutter from 6c3a0e4d21da to a0ef08dec4aa (12 revisions) flutter/packages#2278

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 25, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

2b4bd56

…/flutter#104935)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

edd3647

…/flutter#104935)

engine-flutter-autoroll mentioned this pull request Jun 26, 2022

Roll Flutter from 6c3a0e4d21da to ffa88dbf4680 (15 revisions) flutter/plugins#6043

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 26, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

1c8b52d

…/flutter#104935)

engine-flutter-autoroll mentioned this pull request Jun 27, 2022

Roll Flutter from 6c3a0e4d21da to 3598f20002b5 (16 revisions) flutter/plugins#6046

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

ed68631

…/flutter#104935)

engine-flutter-autoroll mentioned this pull request Jun 28, 2022

Roll Flutter from 6c3a0e4d21da to 7ac9fc5baead (40 revisions) flutter/plugins#6050

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

68062f8

…/flutter#104935)

engine-flutter-autoroll mentioned this pull request Jun 28, 2022

Roll Flutter from 6c3a0e4d21da to 28311e8b868f (41 revisions) flutter/plugins#6051

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

530cd25

…/flutter#104935)

engine-flutter-autoroll mentioned this pull request Jun 28, 2022

Roll Flutter from 6c3a0e4d21da to 1fd3d6c3c934 (42 revisions) flutter/plugins#6052

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

a7c8d53

…/flutter#104935)

engine-flutter-autoroll mentioned this pull request Jun 28, 2022

Roll Flutter from 6c3a0e4d21da to 09c5863b9f79 (45 revisions) flutter/plugins#6053

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

1adb248

…/flutter#104935)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

2bc745c

…/flutter#104935)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

feat(tools): Arbitrary browser flags (closes flutter#65575) (flutter#…

3342ef1

…104935)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

0919b61

…/flutter#104935)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

47f54ac feat(tools): Arbitrary browser flags (closes #65575) (flutter…

f4c06c9

…/flutter#104935)

Gustl22 mentioned this pull request Dec 13, 2022

Add flag to set chrome-specific arguments on flutter run -d chrome dart-lang/webdev#1080

Closed

reynaldots mentioned this pull request May 26, 2025

feat(tool): Respect user-data-dir flag from web-browser-flag #169445

Merged

9 tasks

feat(tools): Arbitrary browser flags (closes #65575) #104935

feat(tools): Arbitrary browser flags (closes #65575) #104935

Uh oh!

Conversation

Gustl22 commented May 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Change policies

Notes

Pre-launch Checklist

Uh oh!

Gustl22 commented Jun 7, 2022

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Gustl22 commented Jun 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopherfujino commented Jun 9, 2022

Uh oh!

Gustl22 commented Jun 10, 2022

Uh oh!

Gustl22 commented Jun 16, 2022

Uh oh!

Uh oh!

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Jun 16, 2022

Uh oh!

Uh oh!

Gustl22 commented Jun 23, 2022

Uh oh!

christopherfujino commented Jun 23, 2022

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Gustl22 commented Jun 24, 2022

Uh oh!

aytunch commented Feb 20, 2023

Uh oh!

Gustl22 commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aytunch commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gustl22 commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balee commented Aug 26, 2023

Uh oh!

Gustl22 commented Aug 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balee commented Aug 26, 2023

Uh oh!

balee commented Aug 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gustl22 commented May 29, 2022 •

edited

Loading

Gustl22 commented Jun 9, 2022 •

edited

Loading

Gustl22 commented Feb 20, 2023 •

edited

Loading

aytunch commented Feb 20, 2023 •

edited

Loading

Gustl22 commented Feb 20, 2023 •

edited

Loading

Gustl22 commented Aug 26, 2023 •

edited

Loading