Skip to content

Use curly_braces_in_flow_control_structures for gen_defaults #104921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 1 commit into from
May 30, 2022
Merged

Use curly_braces_in_flow_control_structures for gen_defaults #104921

guidezpl merged 1 commit into from
May 30, 2022

Conversation

@werainkhatri
Copy link
Member

@werainkhatri werainkhatri commented May 29, 2022

Part of #104498

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 29, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 29, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@werainkhatri werainkhatri changed the title Use curly_braces_in_flow_control_structures for gen_defaults Use curly_braces_in_flow_control_structures for gen_defaults May 29, 2022
@Hixie
Copy link
Contributor

Hixie commented May 29, 2022

test-exempt: formatting

@guidezpl guidezpl merged commit 793e2ef into flutter:master May 30, 2022
@guidezpl guidezpl mentioned this pull request May 30, 2022
Closed
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
2e887ca 
…lutter/flutter#104921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
6403645 
…lutter/flutter#104921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
04791e6 
…lutter/flutter#104921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
bcc8797 
…lutter/flutter#104921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
e6dcc13 
…lutter/flutter#104921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
ee884a4 
…lutter/flutter#104921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
9a86a11 
…lutter/flutter#104921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
4676f22 
…lutter/flutter#104921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
592e471 
…lutter/flutter#104921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
46f7b1c 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
4b4301f 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
02035de 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
17e1bd5 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
fd1751f 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
481e819 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
4a3e594 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
1508e21 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
93af621 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
fffde5a 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
6ac22c3 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
9d9abee 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
b57d23c 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
876823a 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
edf1f40 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
d883e5f 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
71288f5 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
aa7cc67 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
c885b0b 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
5eb5312 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
a3b6dd3 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
7f29a50 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
6e0f823 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
0237e21 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
ba1aa9c 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
3c1d8fa 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
f943e9b 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
7eeceac 
…lutter/flutter#104921)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@werainkhatri @camsim99
Use curly_braces_in_flow_control_structures for gen_defaults (flutter…
546d141 
…#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
394c042 
…lutter/flutter#104921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
793e2ef Use curly_braces_in_flow_control_structures for gen_defaults (f…
7d7259c 
…lutter/flutter#104921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@werainkhatri @Hixie @guidezpl