Skip to content

Add versions to all the dependencies so they are pinned #104867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ricardoamador merged 3 commits into from
Jun 2, 2022
Merged

Add versions to all the dependencies so they are pinned #104867

ricardoamador merged 3 commits into from
Jun 2, 2022

Conversation

@ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented May 27, 2022 •
edited
Loading

Description of The Issue Being Addressed

The builder config is fragile when dependencies are not pinned to specific versions. Any upstream changes may cause breakage. We should create a test to validate all .ci.yaml dependencies are pinned. This also requires that we pin specific versions for all dependencies.

Issues Addressed

#101712

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ricardoamador ricardoamador requested a review from keyonghan as a code owner May 27, 2022 22:47
@CaseyHillers
Copy link
Contributor

CaseyHillers commented May 31, 2022

Fyi some of the checks are failing on ambiguous tags. You'll need to use a unique tag

@ricardoamador
Copy link
Contributor Author

ricardoamador commented May 31, 2022 •
edited
Loading

@CaseyHillers Thanks. I was working on this late and was unable to create a tag. Keyong gave me a version to try though.

@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels May 31, 2022
CaseyHillers
CaseyHillers reviewed Jun 2, 2022
View reviewed changes
.ci.yaml
{"dependency": "apple_signing"}
{"dependency": "xcode", "version": "13a233"},
{"dependency": "gems", "version": "v3.3.14"},
{"dependency": "apple_signing", "version": "none"}
Copy link
Contributor

@CaseyHillers CaseyHillers Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this be none?

Copy link
Contributor Author

@ricardoamador ricardoamador Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah so I spoke with Drew and there is no version associated with this. And in the recipe there is no check on the version for this dependency so rather than leave it blank I just gave it None. I can replace it with something else if it makes more sense.

Copy link
Contributor

@CaseyHillers CaseyHillers Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be a well built tool to not need versions :-)

keyonghan
keyonghan approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoamador ricardoamador changed the title Validate ci yaml deps pinned Add versions to all the dependencies so they are pinned Jun 2, 2022
@ricardoamador ricardoamador merged commit ff110fb into flutter:master Jun 2, 2022
@ricardoamador ricardoamador deleted the validate_ci_yaml_deps_pinned branch June 2, 2022 20:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
8866851 
…ter/flutter#104867)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
6f3d7fb 
…ter/flutter#104867)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
4c5f2d8 
…ter/flutter#104867)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
a6695cc 
…ter/flutter#104867)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
d5d07eb 
…ter/flutter#104867)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
702d6af 
…ter/flutter#104867)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
0fcd0cc 
…ter/flutter#104867)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
7694341 
…ter/flutter#104867)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
49e7f25 
…ter/flutter#104867)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
4640ad9 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
0e8287e 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
3251271 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
f116e64 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
531002a 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
68602f2 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
691fd75 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
c944d2d 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
78ad73c 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
7afc2fa 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
3e87eb3 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
94cd926 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
61b8be3 
…ter/flutter#104867)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@ricardoamador @camsim99
Add versions to all the dependencies so they are pinned (flutter#104867)
852b5eb 
* Updated file to include version for dependencies.

* Updated clang version to use github revision.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
ae5442a 
…ter/flutter#104867)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
ff110fb Add versions to all the dependencies so they are pinned (flut…
e54df67 
…ter/flutter#104867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ricardoamador @CaseyHillers @keyonghan @goderbauer