Removing minor version from device_os value. #104727
Conversation
|
@yusuf-goog |
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM, let's see if we ever hit issues with inconsistencies between minor versions.
Actually this seems related to your PR? I see 3 results for |
|
https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-12 gives only |
|
This will block the tree as |
|
This is blocking the tree now. Revert is here: #104755 |
) This reverts commit 8461e57. Co-authored-by: Jenn Magder <[email protected]>
|
I would have marked requested changes but I thought the failing test would have blocked, but then it passed? https://ci.chromium.org/p/flutter/builders/try/Mac_ios%20hot_mode_dev_cycle_macos_target__benchmark/1571 claims |
|
Sounds the rerun ignores the dimension change. #104758 to track. |
|
@jmagman can you please look at at the failure, so we can remove the minor version dependency. We have a number of iphones at different versions, and its going to keep capacity low. |
Filed #104770 |
flutter#104755) This reverts commit 8461e57. Co-authored-by: Jenn Magder <[email protected]>
4 participants
Bug:103733
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.