Skip to content

(WIP) ContextMenu #104647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinmc wants to merge 91 commits into from
Closed

(WIP) ContextMenu #104647

justinmc wants to merge 91 commits into from

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented May 25, 2022 •
edited
Loading

Design doc

Deprecations

The old way of building a toolbar still works exactly as before, but it's deprecated. That's toolbarOptions and the toolbar-related parts of TextSelectionControls.

  • toolbarOptions
  • buildToolbar
  • canCopy etc.
  • handleCopy etc.

New stuff immediately deprecated

  • "handle controls"
    • Since I have deprecated the parts of TextSelectionControls related to the toolbar, I needed a way to distinguish old TextSelectionControls that still desire to customize the toolbar. To do that, I created a new mixin TextSelectionHandleControls on TextSelectionControls for new usages that don't care about the toolbar. I immediately deprecated TextSelectionHandleControls. When the deprecation is removed, we can remove that class and all TextSelectionControls will only relate to handles and not toolbars.
  • buttonDatasForToolbarOptions
    • For the same reason as the previous point, this method was created and immediately deprecated. It translates between the old toolbarOptions system and the new buttonDatas.

User-side changes

  • Mac no longer shows a "Select all" button. I think we missed this before and native Mac shouldn't show one. I don't ever see one natively, except in the browser.

Open questions

  • TextSelectionToolbarButtonData
    • Is there a way to merge this with Greg's contextual menu data?

justinmc added 29 commits February 1, 2022 12:12
@justinmc
Fake text selection menu in a route
ddbbb4c
@justinmc
buildMenu via InheritedWidget
f0b95a1
@justinmc
Show in overlay instead of route, because new route will always hide …
f7e5a0f 
…selection and focus of underlying route
@justinmc
Class instead of function, so that I can remove
f382ccc
@justinmc
Use the real CupertinoDesktopTextSelectionToolbar with a fake button.
d775e9d
@justinmc
Showing different menu for text, but can I still tie into TextSelecti…
f77d029 
…onControls?
@justinmc
Tied into texteditingoverlay by looking up ContextualMenuAreaState
720ac5b
@justinmc
hideToolbar works too
1adb523
@justinmc
Can build the full Mac desktop menu by copying _CupertinoDesktopTextS…
ecb48bb 
…electionControlsToolbar
@justinmc
Handles both Material and Cupertino desktop toolbars depending on the…
1be82e6 
… theme platform
@justinmc
Merge branch 'master' into context-menu-anywhere
9ef242b
@justinmc
buildToolbar is now unused, desktop and mobile menus work through
e2c89e2 
ContextualMenu.
@justinmc
buildContextualMenu param for overriding text selection toolbar
40635eb
@justinmc
Working for CupertinoTextField too, with buildContextualMenu
441c982
@justinmc
No more dependencies on controls/delegate, and bug fixed where menu w…
52d6ce2 
…as hidden permanently
@justinmc
Reorganize contextual menu classes: InheritedContextualMenu and Conte…
18bee98 
…xtualMenuController
@justinmc
Viable running public API. Need ability to easily edit label.
a7a4b74
@justinmc
Can pass label in button datas
61a6845
@justinmc
Text buttons hide the menu correctly, and pass the controller so othe…
d960ae1 
…r buttons can too
@justinmc
Merge branch 'master' into context-menu-anywhere
f9c9538
@justinmc
Public ContextualMenuGestureDetector
a904130
@justinmc
Use existing ModalBarrier
6a34933
@justinmc
TextFormField support
b38999d
@justinmc
copyWith for ContextualMenuButtonData
fd146ba
@justinmc
Remove private gesture detector since it's now public
a93d010
@justinmc
SelectableText support
84a505b
@justinmc
TODO: replace deprated uses of canCopy et. al.
387a19f
@justinmc
InheritedContextualMenu => ContextMenu
e1dedfe
@justinmc
Split out ClipboardStatusBuilder
960edda
@justinmc justinmc self-assigned this May 25, 2022
justinmc added 18 commits June 27, 2022 11:18
@justinmc
Docs ref fix
0c02e75
@justinmc
Fix text_selection_toolbar_test
4f65485
@justinmc
Display below the primary anchor if there is no secondary anchor
68e1796
@justinmc
Fix mixup of selectionControls and buildContextMenu
3fa1cb1
@justinmc
Fix semantics tests by restoring original behavior while deprectated …
1690266 
…code is still around
@justinmc
Fix reference to removed class _selectiontoolbaroverlay
95e0785
@justinmc
Build handle versions of controls as material does, for deprecating b…
19f070c 
…uildToolbar et.al.
@justinmc
Allow overriding defaultTargetPlatform. Now Cupertino contextmenus wi…
04ea73e 
…ll always have the iOS/Mac buttons, not be hybrids on other platforms
@justinmc
Rest of cupertino_text_field_tests passing, fixed secondaryAnchor req…
b714c07 
…uirement like material, and fixed positioning with padding
@justinmc
Merge branch 'master' into context-menu-anywhere
0b247e3
@justinmc
'Handle' selection controls used in selectabletext
4d97b0c
@justinmc
Fix selectabletext tests that were tapping on the toolbar
1c5ac8f
@justinmc
SelectablRegion can show toolbar like normal, handled by selectionove…
e31a125 
…rlay
@justinmc
emtpy buildContextMenu params unnecessary in selectable_region_test
44acddc
@justinmc
Remove unnecessary custom buildContextMenu from selectable_region_test
8270157
@justinmc
Bring back takassh's scrolled toolbar position fix, which I must have…
dcb8e5d 
… missed in a merge
@justinmc
Spelling
c9c7fea
@justinmc
Merge branch 'master' into context-menu-anywhere
aa58c05
@justinmc justinmc mentioned this pull request Jul 1, 2022
Closed
@justinmc justinmc mentioned this pull request Jul 6, 2022
Merged
@justinmc
Copy link
Contributor Author

justinmc commented Jul 8, 2022

Closing in an attempt to fix the customer tests that are incorrectly failing. If that doesn't work then I'll use a squashed version of this PR (#107193).

@justinmc justinmc closed this Jul 8, 2022
@justinmc justinmc deleted the context-menu-anywhere branch July 8, 2022 16:31
This was referenced Jul 8, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@justinmc justinmc

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@justinmc