Skip to content

Use curly_braces_in_flow_control_structures for non-flutter packages #104629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 9 commits into from
May 25, 2022
Merged

Use curly_braces_in_flow_control_structures for non-flutter packages #104629

guidezpl merged 9 commits into from
May 25, 2022

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented May 25, 2022

Part of #104498

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guidezpl guidezpl requested a review from goderbauer May 25, 2022 16:11
@guidezpl guidezpl requested a review from Piinks as a code owner May 25, 2022 16:11
@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 25, 2022
@guidezpl guidezpl mentioned this pull request May 25, 2022
Closed
11 tasks
goderbauer
goderbauer approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

@Hixie
Copy link
Contributor

Hixie commented May 25, 2022

test-exempt: formatting change

Piinks
Piinks approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guidezpl guidezpl merged commit 74cfc3d into flutter:master May 25, 2022
@guidezpl guidezpl deleted the curlyyyyyyyyy branch May 25, 2022 18:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2022
@engine-flutter-autoroll
74cfc3d Use curly_braces_in_flow_control_structures for non-`flutte…
46a66d1 
…r` packages (flutter/flutter#104629)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
74cfc3d Use curly_braces_in_flow_control_structures for non-`flutte…
c53b349 
…r` packages (flutter/flutter#104629)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
74cfc3d Use curly_braces_in_flow_control_structures for non-`flutte…
bf0da76 
…r` packages (flutter/flutter#104629)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Use curly_braces_in_flow_control_structures for non-flutter packa…
67daddb 
…ges (flutter#104629)

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_test`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins`

* fix comments

* Use `curly_braces_in_flow_control_structures` for `packages/integration_test`

* fix indentation
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
74cfc3d Use curly_braces_in_flow_control_structures for non-`flutte…
8ba57b9 
…r` packages (flutter/flutter#104629)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
74cfc3d Use curly_braces_in_flow_control_structures for non-`flutte…
852dd5b 
…r` packages (flutter/flutter#104629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guidezpl @Hixie @goderbauer @Piinks