Skip to content

Use curly_braces_in_flow_control_structures for sample code #104617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 4 commits into from
May 26, 2022
Merged

Use curly_braces_in_flow_control_structures for sample code #104617

guidezpl merged 4 commits into from
May 26, 2022

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented May 25, 2022 •
edited
Loading

Part of #104498

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guidezpl guidezpl requested a review from goderbauer May 25, 2022 14:50
@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 25, 2022
@guidezpl guidezpl mentioned this pull request May 25, 2022
Closed
11 tasks
guidezpl
guidezpl commented May 25, 2022
View reviewed changes
Copy link
Member Author

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff to review is guidezpl@fffe900, the rest is from updating packages.

@guidezpl
Copy link
Member Author

guidezpl commented May 25, 2022

The addition to examples/api/pubspec.yaml gets wiped when updating packages, what to do?

@goderbauer
Copy link
Member

goderbauer commented May 25, 2022

The addition to examples/api/pubspec.yaml gets wiped when updating packages, what to do?

Likely because of this: guidezpl@fffe900#r74497341

@goderbauer
Copy link
Member

goderbauer commented May 25, 2022

Looks like the only difference is that flutter_lints is enforcing the curly_braces_in_flow_control_structures lint. I thought you are adding to the set of lints enforced in the repository as part of #104498, so that difference would go away soon.

I actually prefer the stricter set of lints we have enabled in the repository over flutter_lints because I think it produces even more readable sample code (e.g. you have to type everything). I believe, every lint that's part of flutter_lints is also already enforced in the repository (with the exception of the curly lint mentioned, but that's hopefully about to change). So, code that's clean under the repository lints should also be clean under flutter_lints (but not necessarily the other way around).

So, overall, I think switching the samples to flutter_lints would be a step back.

@guidezpl
Copy link
Member Author

guidezpl commented May 25, 2022

Makes sense, I'll repurpose this to just fix the curly_braces_in_flow_control_structures.

@guidezpl guidezpl changed the title Use flutter_lints for sample code Use curly_braces_in_flow_control_structures for sample code May 25, 2022
@guidezpl guidezpl marked this pull request as ready for review May 25, 2022 17:25
goderbauer
goderbauer approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidezpl guidezpl merged commit 308b543 into flutter:master May 26, 2022
@guidezpl guidezpl deleted the curlyy branch May 26, 2022 06:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
e1132d7 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
99ac1cc 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
469b951 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
3dd72e6 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
8a1c7d4 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
38fd297 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
21835c9 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
7861409 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
4f426af 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
5fa8093 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
93d4986 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
c0c136c 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
f89d0ba 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
c41c6de 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
16097c4 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
0fdf82d 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
9af7d51 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
8451e4b 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
a3f9625 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
ccb52a5 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
7e36300 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
3ae858c 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
40f0d14 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
dab3a1f 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
bfb5523 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
6052a2e 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
9f51746 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
32469b3 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
2f9505f 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
fc8e2da 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
64284b6 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
de9aeef 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
eb737f0 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
47984df 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
80fb5bf 
flutter/flutter#104617)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Use curly_braces_in_flow_control_structures for sample code (flutt…
f0506fc 
…er#104617)

* use `flutter_lints` for sample code

* update packages

* Revert "update packages"

This reverts commit 14da3c6.

* revert
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
651c052 
flutter/flutter#104617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
308b543 Use curly_braces_in_flow_control_structures for sample code (
976a018 
flutter/flutter#104617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guidezpl @goderbauer