Skip to content

Use curly_braces_in_flow_control_structures for widgets #104609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 4 commits into from
May 26, 2022
Merged

Use curly_braces_in_flow_control_structures for widgets #104609

guidezpl merged 4 commits into from
May 26, 2022

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented May 25, 2022 •
edited
Loading

Part of #104498

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems f: focus Focus traversal, gaining or losing focus f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels May 25, 2022
@guidezpl guidezpl requested a review from goderbauer May 25, 2022 14:25
@guidezpl guidezpl mentioned this pull request May 25, 2022
Closed
11 tasks
goderbauer
goderbauer approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

too large too look at every single change :)

@guidezpl
Copy link
Member Author

guidezpl commented May 25, 2022

I spacebared my way through all of these PRs to identify comment issues, I'm 99% sure this is fine :)

@Hixie
Copy link
Contributor

Hixie commented May 25, 2022

test-exempt: formatting change

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 26, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@guidezpl
Copy link
Member Author

guidezpl commented May 26, 2022

Merging as internal issues prevent Google testing from completing, please revert if this causes issues.

@guidezpl guidezpl merged commit 2aa348b into flutter:master May 26, 2022
@guidezpl guidezpl deleted the curlyyy branch May 26, 2022 07:48
@nilsreichardt nilsreichardt mentioned this pull request May 26, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
d7eef0d 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
91cc2d6 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
74de51d 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
b3da2f8 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
f34388f 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
ac6d3de 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
96f83f3 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
99b6a2f 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
c854e5c 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
244613b 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
8c227f6 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
b0ab377 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
f10a87a 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
a8d429d 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
9a79259 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
f670d93 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
989a3e0 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
9ea4e34 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
8bdf7c6 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
7ebd9f0 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
0453d70 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
039fc59 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
60fe81b 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
4f7ea10 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
466ce97 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
f7cc308 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
80d9ae9 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
76e1cd9 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
0510a7d 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
d8c0f89 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
9bdd0fe 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
3192e50 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
b8dab4f 
…lutter/flutter#104609)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Use curly_braces_in_flow_control_structures for widgets (flutter#…
bf4bb74 
…104609)

* Use `curly_braces_in_flow_control_structures` for `widgets`

* fix comments

* fix comments
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
9410b30 
…lutter/flutter#104609)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
2aa348b Use curly_braces_in_flow_control_structures for widgets (f…
64f5c2e 
…lutter/flutter#104609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems f: focus Focus traversal, gaining or losing focus f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guidezpl @Hixie @fluttergithubbot @goderbauer