Skip to content

Dispose ValueNotifier in EditableTextState #104590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 25, 2022
Merged

Dispose ValueNotifier in EditableTextState #104590

fluttergithubbot merged 1 commit into from
May 25, 2022

Conversation

@tgucio
Copy link
Contributor

@tgucio tgucio commented May 25, 2022

This PR adds dispose() calls for a ValueNotifier created in EditableTextState.

Test exempt: preventive / "good practice" dispose.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented May 25, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels May 25, 2022
Hixie
Hixie approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test-exempt: in theory the result should be indistinguishable since when the state is disposed the listeners should be removed also, so "refactor with no semantic change"

werainkhatri
werainkhatri approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM

@fluttergithubbot fluttergithubbot merged commit aa1c43b into flutter:master May 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2022
@engine-flutter-autoroll
aa1c43b Dispose ValueNotifier in EditableTextState (flutter/flutter#1…
1026701 
…04590)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
aa1c43b Dispose ValueNotifier in EditableTextState (flutter/flutter#1…
694b266 
…04590)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
aa1c43b Dispose ValueNotifier in EditableTextState (flutter/flutter#1…
e081134 
…04590)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@tgucio @camsim99
Dispose ValueNotifier in EditableTextState (flutter#104590)
6b36d66
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
aa1c43b Dispose ValueNotifier in EditableTextState (flutter/flutter#1…
2062a2f 
…04590)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
aa1c43b Dispose ValueNotifier in EditableTextState (flutter/flutter#1…
409270d 
…04590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@werainkhatri werainkhatri werainkhatri approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tgucio @Hixie @werainkhatri @fluttergithubbot