[framework] ensure ink sparkle is disposed #104569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Tests updated |
jonahwilliams
commented
May 25, 2022
| final Finder buttonFinder = find.text('Sparkle!'); | ||
| await tester.tap(buttonFinder); | ||
| await tester.pump(); | ||
| await tester.pumpAndSettle(); |
Contributor
Author
There was a problem hiding this comment.
Im not really sure why this worked before. I think pumpAndSettling past the animation duration still worked since we would continue painting it forever
dnfield
reviewed
May 25, 2022
|
|
||
| void _handleStatusChanged(AnimationStatus status) { | ||
| if (status == AnimationStatus.completed) | ||
| dispose(); |
Contributor
There was a problem hiding this comment.
can we test this?
For example, add some kind of debugHasFeature API on MaterialInkController and assert in a test that once the animation is done the controller doesn't contain this feature anymore?
Contributor
Author
There was a problem hiding this comment.
MaterialInkController is often implemented, so adding debugHasFeature may be breaking
Contributor
|
This should get cherry-picked into stable when it lands. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 25, 2022
dnfield
pushed a commit
to dnfield/flutter
that referenced
this pull request
Jun 1, 2022
itsjustkevin
added a commit
that referenced
this pull request
Jun 2, 2022
* [framework] ensure ink sparkle is disposed (#104569) * CI Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Kevin Chisholm <[email protected]>
bernard-lee
added a commit
to bernard-lee/flutter
that referenced
this pull request
Jun 29, 2022
* 'stable' of https://github.com/flutter/flutter: (1203 commits) 'Update Engine revision to ffe7b86a1e5b5cb63c8385ae1adc759e372ee8f4 for stable release 3.0.3' (flutter#106431) [flutter_releases] Removing minor iOS version filter value from ci.yaml (flutter#105059) (flutter#105629) [flutter_releases] Flutter stable 3.0.2 Framework Cherrypicks (flutter#105528) [framework] ensure ink sparkle is disposed (flutter#104569) (flutter#105144) [CP] Fix Flutter doctor crash on Windows caused by bad UTF8 from vswhere.exe (flutter#105153) [tool][web] Use 'constructor' instead of 'public field declarations' in flutter.js (Safari 13) (flutter#105162) [flutter_releases] Cherrypicks for SliverReorderableList and Slider regressions (flutter#105141) 'Update Engine revision to caaafc5604ee9172293eb84a381be6aadd660317 for stable release 3.0.1' (flutter#104213) [flutter_releases] Flutter stable 2.13.0 Framework Cherrypicks (flutter#103375) [flutter_releases] Flutter beta 2.13.0-0.4.pre Framework Cherrypicks (flutter#103101) Enforce cpu explicitly for Mac devicelab test beds (flutter#101871) (flutter#102685) [flutter_releases] Flutter beta 2.13.0-0.3.pre Framework Cherrypicks (flutter#102620) [flutter_releases] Upgrade dwds to 12.1.1 (flutter#101546) [flutter_releases] Flutter beta 2.13.0-0.2.pre Framework Cherrypicks (flutter#102193) [flutter_releases] Flutter beta 2.12.0-4.1.pre Framework Cherrypicks (flutter#101771) [flutter_releases] Cherrypick engine to c341645 (flutter#101608) Revert "Refactor `ToggleButtons` (remove `RawMaterialButton`) (flutter#99493)" (flutter#101538) [Cherrypick] Partial revert of super params in tools (flutter#101436) (flutter#101527) Roll Engine from e7e7ca1 to b48d65e (10 revisions) (flutter#101370) [flutter_tools] port bash script to use sysctl not uname on macOS (flutter#101308) ...
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104545
Fixes #104229
The ink sparkle is never disposed, leading to a massive saveLayer buildup