Skip to content

Cleanup random dead test code #104568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 25, 2022
Merged

Cleanup random dead test code #104568

fluttergithubbot merged 1 commit into from
May 25, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented May 25, 2022

Same as #104550, but for our other packages.

@goderbauer goderbauer requested a review from Piinks as a code owner May 25, 2022 00:14
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 25, 2022
chunhtai
chunhtai approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 2b14e99 into flutter:master May 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2022
@engine-flutter-autoroll
2b14e99 Cleanup random dead test code (flutter/flutter#104568)
2300d63
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2022
@engine-flutter-autoroll
2b14e99 Cleanup random dead test code (flutter/flutter#104568)
20e51db
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
2b14e99 Cleanup random dead test code (flutter/flutter#104568)
ebbfe5a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
2b14e99 Cleanup random dead test code (flutter/flutter#104568)
a7a5f04
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@goderbauer @camsim99
Cleanup random dead test code (flutter#104568)
1da8eda
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
2b14e99 Cleanup random dead test code (flutter/flutter#104568)
5e9beaa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
2b14e99 Cleanup random dead test code (flutter/flutter#104568)
00c1b08
@goderbauer goderbauer deleted the more-clean-up branch March 3, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @chunhtai @fluttergithubbot