IntelliJ and Flutter plugin version checks #10454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
tvolkert
reviewed
Jun 2, 2017
| final Version version = new Version.parse(versionText); | ||
| if (version != null && minVersion != null && version < minVersion) { | ||
| messages.add(new ValidationMessage.error( | ||
| '$title plugin ${version != null ? "version $versionText" : "installed"}' |
Contributor
There was a problem hiding this comment.
version is guaranteed to be non-null here.
tvolkert
reviewed
Jun 2, 2017
| final List<ValidationMessage> messages = <ValidationMessage>[]; | ||
| ValidationType type = ValidationType.missing; | ||
| final String studioVersionText = 'version ${_studio.version}'; | ||
| final String studioVersionText = Version.unknown == _studio.version |
Contributor
There was a problem hiding this comment.
Nit: _studio.version == Version.unknown
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version unknownwhen we don't discover a version for android studio, just don't print a version