[flutter roll] Revert "Add ability for ModalRoutes to ignore pointers during trans…
#104520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itions and do so on `Cupertino` routes (flutter#95757)" This reverts commit 4c0b0be.
flutter-dashboard
bot
added
a: tests
Member
|
Please briefly add some context why this was reverted for people who want to look at this again in the future and cc the original author for their information that it got reverted. |
chunhtai
changed the title
ModalRoutes to ignore pointers during trans…ModalRoutes to ignore pointers during trans…
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 24, 2022
…ng transitions and do so on `Cupertino` routes (#95757)" (flutter/flutter#104520)
XilaiZhang
added a commit
to XilaiZhang/flutter
that referenced
this pull request
May 24, 2022
…itions and do so on `Cupertino` routes (flutter#95757)" (flutter#104520) This reverts commit 4c0b0be.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 24, 2022
…ng transitions and do so on `Cupertino` routes (#95757)" (flutter/flutter#104520)
CaseyHillers
pushed a commit
that referenced
this pull request
May 24, 2022
Contributor
|
@XilaiZhang what was the issue here? Anything I can help with? |
Contributor
Author
|
yes sir i copied the error msg to #95757 (comment). I am not sure if there is an open source version of the test you can reference |
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…itions and do so on `Cupertino` routes (flutter#95757)" (flutter#104520) This reverts commit 4c0b0be.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
…ng transitions and do so on `Cupertino` routes (#95757)" (flutter/flutter#104520)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
…ng transitions and do so on `Cupertino` routes (#95757)" (flutter/flutter#104520)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…itions and do so on
Cupertinoroutes (#95757)"This reverts commit 4c0b0be.