Skip to content

TimePicker : Ability to define dialOnly / inputOnly modes #104491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Jun 8, 2022
Merged

TimePicker : Ability to define dialOnly / inputOnly modes #104491

fluttergithubbot merged 2 commits into from
Jun 8, 2022

Conversation

@LempereurBenjamin
Copy link
Contributor

@LempereurBenjamin LempereurBenjamin commented May 24, 2022

Content

  • Add dialOnly mode to the TimePicker
  • Add inputOnly mode to the TimePicker

Issues fixed by this PR

Comments

Inspired by this abandoned PR : #85189

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 24, 2022
@LempereurBenjamin
Copy link
Contributor Author

LempereurBenjamin commented May 24, 2022

Dear @darrenaustin ,
Please can you review this PR ?
I mentioned you because you already reviewed the original PR (#85189).
Thank you.

darrenaustin
darrenaustin suggested changes May 25, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Looks great. Can we just update the docs for TimePickerEntryMode to more closely match the DatePickerEntryMode? I think that would make it a little clearer what the different values are used for.

packages/flutter/lib/src/material/time_picker.dart
dialOnly,

/// Only text input.
inputOnly
Copy link
Contributor

@darrenaustin darrenaustin May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we expand on the docs for all four of of these values to be consistent with how they are described for the equivalent in the Date Picker:

flutter/packages/flutter/lib/src/material/date.dart

Line 158 in cb9a1d6

enum DatePickerEntryMode {

Copy link
Contributor Author

@LempereurBenjamin LempereurBenjamin May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @darrenaustin,
Thank you for the feedback. I made the change in the TimePickerEntryMode doc to match the DatePicker equivalent.
Benjamin.

darrenaustin
darrenaustin approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in response. Thanks for the contribution.

LGTM

Piinks
Piinks approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

justinmc
justinmc approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fluttergithubbot fluttergithubbot merged commit c150c5a into flutter:master Jun 8, 2022
This was referenced Jun 9, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
86cec18 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
2440dce 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
ad290fd 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
71c9ca2 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
24fb8c2 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
cc7b829 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
824bddc 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
45008bc 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
4dc9d5a 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
945b81a 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
f1c299d 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
b0646a0 
…utter/flutter#104491)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
4f62915 
…utter/flutter#104491)
@HansMuller HansMuller mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
e917d9c 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
6ac42ef 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
ce999b9 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
29c7837 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
aa94ff6 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
4dfd1c2 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
08c7c90 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
c1f53c2 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
d1aa9e2 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
f00e500 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
94aaf1c 
…utter/flutter#104491)
@darrenaustin darrenaustin mentioned this pull request Jul 11, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@LempereurBenjamin @camsim99
TimePicker : Ability to define dialOnly / inputOnly modes (flutter#10…
773e1ff 
…4491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
7d1e69e 
…utter/flutter#104491)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
c150c5a TimePicker : Ability to define dialOnly / inputOnly modes (fl…
5742112 
…utter/flutter#104491)
@Vedsaga
Copy link

Vedsaga commented Oct 25, 2022

@darrenaustin which flutter version this is supported? ca you pls confirm

@justinmc
Copy link
Contributor

justinmc commented Oct 25, 2022

This has been released on all channels including stable. I think it went in at v.3.3.0-0.0.pre. Definitely the latest stable v3.3.5 has it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@Piinks Piinks Piinks approved these changes

+1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LempereurBenjamin @Vedsaga @justinmc @darrenaustin @Piinks @fluttergithubbot