Skip to content

Fix BottomAppBar dip without FAB #104490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 24, 2022
Merged

Fix BottomAppBar dip without FAB #104490

fluttergithubbot merged 1 commit into from
May 24, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented May 24, 2022

fixes #104226

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 24, 2022
@fluttergithubbot fluttergithubbot merged commit a12a69a into flutter:master May 24, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 24, 2022
@engine-flutter-autoroll
a12a69a Fix BottomAppBar dip without FAB (flutter/flutter#104490)
45da503
@TahaTesser TahaTesser deleted the fix_bottom_app_dip branch May 24, 2022 10:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 24, 2022
@engine-flutter-autoroll
a12a69a Fix BottomAppBar dip without FAB (flutter/flutter#104490)
c8ab5c8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 24, 2022
@engine-flutter-autoroll
a12a69a Fix BottomAppBar dip without FAB (flutter/flutter#104490)
af63a1c
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@TahaTesser @camsim99
Fix BottomAppBar dip without FAB (flutter#104490)
a7dc425
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
a12a69a Fix BottomAppBar dip without FAB (flutter/flutter#104490)
19e7ce8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
a12a69a Fix BottomAppBar dip without FAB (flutter/flutter#104490)
eaab071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bottom App Bar + Sheet Causes Dimple

3 participants

@TahaTesser @guidezpl @fluttergithubbot