Add flags to pass '--enable-software-rendering' flag to engine in run command #10449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
changed the title
yjbanov
approved these changes
Jun 2, 2017
| negatable: false, | ||
| help: 'Enable rendering using the Skia software backend. This is useful\n' | ||
| 'when testing Flutter on emulators. By default, Flutter will\n' | ||
| 'attempt to either use OpenGL or Vulkan.'); |
Contributor
There was a problem hiding this comment.
nit: suggest ending the last sentence with "and will fallback to software rendering when neither are available."
Contributor
Author
There was a problem hiding this comment.
This is not yet the case, but I'll add it in a second!
yjbanov
approved these changes
Jun 2, 2017
| defaultsTo: false, | ||
| negatable: false, | ||
| help: 'Start in a paused mode and wait for a debugger to connect.'); | ||
| argParser.addFlag('enable-software-rendering', |
Contributor
There was a problem hiding this comment.
Are these options shared with flutter drive command? If not, could you add it there too?
| cmd.addAll(<String>['--ez', 'trace-startup', 'true']); | ||
| if (route != null) | ||
| cmd.addAll(<String>['--es', 'route', route]); | ||
| if (enableSoftwareRendering || debuggingOptions.enableSoftwareRendering) |
Member
There was a problem hiding this comment.
Can these two flags be reduced into one?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.