Skip to content

Fix ColorScheme.copyWith for surfaceTint #104435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 1 commit into from
May 24, 2022
Merged

Fix ColorScheme.copyWith for surfaceTint #104435

darrenaustin merged 1 commit into from
May 24, 2022

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented May 23, 2022 •
edited
Loading

Fixed a typo in ColorScheme.copyWith that caused surfaceTint to not be properly overridden.

Fixes: #104350

Added a new test for copyWith to verify it works properly.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 23, 2022
@darrenaustin darrenaustin mentioned this pull request May 23, 2022
Closed
gspencergoog
gspencergoog approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Wow, there's a subtle bug...

@darrenaustin darrenaustin merged commit eadd07b into flutter:master May 24, 2022
@darrenaustin darrenaustin deleted the surface_tint_copy branch May 24, 2022 03:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 24, 2022
@engine-flutter-autoroll
eadd07b Fix ColorScheme.copyWith for surfaceTint (flutter/flutter#104435
f32c247 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 24, 2022
@engine-flutter-autoroll
eadd07b Fix ColorScheme.copyWith for surfaceTint (flutter/flutter#104435
8924ac6 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 24, 2022
@engine-flutter-autoroll
eadd07b Fix ColorScheme.copyWith for surfaceTint (flutter/flutter#104435
45005b4 
)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@darrenaustin @camsim99
Fix ColorScheme.copyWith for surfaceTint (flutter#104435)
b95e540
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
eadd07b Fix ColorScheme.copyWith for surfaceTint (flutter/flutter#104435
57305c8 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
eadd07b Fix ColorScheme.copyWith for surfaceTint (flutter/flutter#104435
cce4d97 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

surfaceTint, field of ColorScheme, can’t be overwritten

2 participants

@darrenaustin @gspencergoog