Roll engine to d882b2d12375a4ae54baeccd2f7b0aafef422831 #104431
Conversation
Manual engine roll to work around flutter#104387 d882b2d Revert "Use CIPD to download prebuilt Dart SDKs (flutter#33345)" (flutter#33558) 4bff087 Roll Skia from d3cbea4114aa to 86323276b2fc (4 revisions) (flutter#33556) 80b183e [Windows] Add textScaleFactor support (flutter#33316) 9388aa1 Roll Fuchsia Mac SDK from SmBoqSpQQ... to 1URI3xQBh... (flutter#33554) 98be801 Roll Fuchsia Linux SDK from t9KwJZBWT... to KG9Y2q6J-... (flutter#33553) 0c591bf Roll Skia from fb7f03aeac6e to d3cbea4114aa (1 revision) (flutter#33550) 945cb27 reduce the number of dependencies declared by flutter_frontend_server (flutter#33520) 76137e8 Roll Fuchsia Mac SDK from yKCDVbBgS... to SmBoqSpQQ... (flutter#33542) dc49d18 Roll Fuchsia Linux SDK from 3mdV9nX-U... to t9KwJZBWT... (flutter#33541) 6a4c45a Roll Dart SDK from d3e96bbc3d87 to 7fa990079a0a (1 revision) (flutter#33540) 5a3a0c1 Roll Skia from ade84dfd2ba5 to fb7f03aeac6e (1 revision) (flutter#33539) 4db98a0 Roll Fuchsia Mac SDK from 1QcM2qaSN... to yKCDVbBgS... (flutter#33538) f13d03c Roll Dart SDK from 708801716094 to d3e96bbc3d87 (1 revision) (flutter#33537) 2d3affd Roll Fuchsia Linux SDK from asLtG1Pbw... to 3mdV9nX-U... (flutter#33536) dfa4724 Roll Dart SDK from 90d5fdb9368b to 708801716094 (1 revision) (flutter#33534)
flutter-dashboard
bot
added
the
engine
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Mac customer_testing is failing because of this issue; however, for some reason, it's pulling the Dart SDK from a different engine commit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8813351746689368545/+/u/Customer_testing/customer_testing/test_stderr I believe this is an infra issue. I locally checked this commit, and the mac tool compiles, and the dart sdk is NOT codesigned. |
I filed an infra ticket queue bug for this #104433. I believe we will have to disregard this failure to unblock fixing the tree. |
|
The other checks aren't running because of the failing |
SGTM merged |
|
test-exempt: rolling dependency |
Manual engine roll to work around flutter#104387 d882b2d Revert "Use CIPD to download prebuilt Dart SDKs (flutter#33345)" (flutter#33558) 4bff087 Roll Skia from d3cbea4114aa to 86323276b2fc (4 revisions) (flutter#33556) 80b183e [Windows] Add textScaleFactor support (flutter#33316) 9388aa1 Roll Fuchsia Mac SDK from SmBoqSpQQ... to 1URI3xQBh... (flutter#33554) 98be801 Roll Fuchsia Linux SDK from t9KwJZBWT... to KG9Y2q6J-... (flutter#33553) 0c591bf Roll Skia from fb7f03aeac6e to d3cbea4114aa (1 revision) (flutter#33550) 945cb27 reduce the number of dependencies declared by flutter_frontend_server (flutter#33520) 76137e8 Roll Fuchsia Mac SDK from yKCDVbBgS... to SmBoqSpQQ... (flutter#33542) dc49d18 Roll Fuchsia Linux SDK from 3mdV9nX-U... to t9KwJZBWT... (flutter#33541) 6a4c45a Roll Dart SDK from d3e96bbc3d87 to 7fa990079a0a (1 revision) (flutter#33540) 5a3a0c1 Roll Skia from ade84dfd2ba5 to fb7f03aeac6e (1 revision) (flutter#33539) 4db98a0 Roll Fuchsia Mac SDK from 1QcM2qaSN... to yKCDVbBgS... (flutter#33538) f13d03c Roll Dart SDK from 708801716094 to d3e96bbc3d87 (1 revision) (flutter#33537) 2d3affd Roll Fuchsia Linux SDK from asLtG1Pbw... to 3mdV9nX-U... (flutter#33536) dfa4724 Roll Dart SDK from 90d5fdb9368b to 708801716094 (1 revision) (flutter#33534)
4 participants
Manual engine roll to work around #104387
d882b2d Revert "Use CIPD to download prebuilt Dart SDKs (#33345)" (#33558)
4bff087 Roll Skia from d3cbea4114aa to 86323276b2fc (4 revisions) (#33556)
80b183e [Windows] Add textScaleFactor support (#33316)
9388aa1 Roll Fuchsia Mac SDK from SmBoqSpQQ... to 1URI3xQBh... (#33554)
98be801 Roll Fuchsia Linux SDK from t9KwJZBWT... to KG9Y2q6J-... (#33553)
0c591bf Roll Skia from fb7f03aeac6e to d3cbea4114aa (1 revision) (#33550)
945cb27 reduce the number of dependencies declared by flutter_frontend_server (#33520)
76137e8 Roll Fuchsia Mac SDK from yKCDVbBgS... to SmBoqSpQQ... (#33542)
dc49d18 Roll Fuchsia Linux SDK from 3mdV9nX-U... to t9KwJZBWT... (#33541)
6a4c45a Roll Dart SDK from d3e96bbc3d87 to 7fa990079a0a (1 revision) (#33540)
5a3a0c1 Roll Skia from ade84dfd2ba5 to fb7f03aeac6e (1 revision) (#33539)
4db98a0 Roll Fuchsia Mac SDK from 1QcM2qaSN... to yKCDVbBgS... (#33538)
f13d03c Roll Dart SDK from 708801716094 to d3e96bbc3d87 (1 revision) (#33537)
2d3affd Roll Fuchsia Linux SDK from asLtG1Pbw... to 3mdV9nX-U... (#33536)
dfa4724 Roll Dart SDK from 90d5fdb9368b to 708801716094 (1 revision) (#103835)