[fuchsia_reload] Use ssh instead of netcp/netruncmd #10436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @abarth |
Hixie
reviewed
Jun 7, 2017
Contributor
There was a problem hiding this comment.
nit: the syntax for TODOs is // TODO(username): message
Contributor
|
cc @tvolkert |
tvolkert
reviewed
Jun 12, 2017
Contributor
There was a problem hiding this comment.
Use processManager.run() so this can be mocked out in tests.
Then, can you add a test? :-)
Contributor
|
BTW, this was checked in when the tree was red. Please avoid checking anything in when the tree is red except for attempts to fix the tree, because it makes it much harder to detect, and later identify, additional failures introduced while the previous failure was ongoing. Thanks! |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change passes the address from the command line to ssh. It could instead get the ipv6 address from netaddr --fuchsia, but I haven't been able to get that to work with my setup.