move getTransformTo method from RenderBox to RenderObject. #10430
Conversation
|
No changes to the method other than promoting it to the base class as it is convenient for all RenderObject instances. |
| assert(child.parent == this); | ||
| } | ||
|
|
||
| /// Returns a matrix that maps the local coordinate system to the coordinate |
There was a problem hiding this comment.
As documented, this doesn't really make sense. e.g. RenderSlivers and RenderSectors don't use the cartesian coordinate system for layout, so it's not clear what a Matrix4 means.
The fix, I think, is just to change the documentation to clarify that this refers to the paint coordinate system, and that specifically this is just applying applyPaintTransform up the tree.
There was a problem hiding this comment.
Updated comment. Not 100% thrilled with the result so please let me know if you have a suggestion that reads better.
|
Can you add a test that this works for non-box render objects? With a test and the fix to the documentation, LGTM. |
|
Added a test and updated the comment. |
|
|
|
@jacob314 Is this ready to land? |
|
There seems to be no reason not to land this so I'm landing it. |
…0430) * move getTransformTo method from RenderBox to RenderObject. * Cleanup comment. Add slivers test.
3 participants
No description provided.