Skip to content

Mention that NavigationBar is a new widget #104264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 1 commit into from
May 20, 2022
Merged

Mention that NavigationBar is a new widget #104264

guidezpl merged 1 commit into from
May 20, 2022

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented May 20, 2022

#88888

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guidezpl guidezpl requested a review from darrenaustin May 20, 2022 15:13
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 20, 2022
darrenaustin
darrenaustin approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@guidezpl guidezpl merged commit 1e1f4bc into master May 20, 2022
@guidezpl guidezpl deleted the guidezpl-patch-1 branch May 20, 2022 23:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2022
@engine-flutter-autoroll
1e1f4bc Mention that NavigationBar is a new widget (flutter/flutter…
2dab37f 
…#104264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
1e1f4bc Mention that NavigationBar is a new widget (flutter/flutter…
b50c5f5 
…#104264)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Mention that NavigationBar is a new widget (flutter#104264)
63a741f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
1e1f4bc Mention that NavigationBar is a new widget (flutter/flutter…
136edbc 
…#104264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
1e1f4bc Mention that NavigationBar is a new widget (flutter/flutter…
43dd08d 
…#104264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guidezpl @darrenaustin