Revert "[framework] inline AbstractNode into RenderObject" #104257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 24bd28f.
Contributor
Author
|
Putting this up in case we don't have time to update the internal fix today |
Contributor
|
Did I mess up the g3fix, or were there more internal cases I didn't hit beyond those? |
Contributor
Author
|
I'm seeing a few instances of: |
Contributor
Author
|
Based on the blame list, I'm pretty sure this was the culprit PR, but FRoB didn't have time to bisect the breakage beyond quickly looking at the blame list of render/object.dart |
Contributor
|
Lets revert for now, if you could send me the failure log I can take a look at it later and figure out what tests were missed. FWIW the frob run got stuck so I manually patched it in and ran tests in g3, so I hit skip on google tests for the original PR. |
flutter-dashboard
bot
added
a: tests
Contributor
|
That particular failure can probably be fixed by making |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2022
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 20, 2022
CaseyHillers
pushed a commit
that referenced
this pull request
May 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 21, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #103832
Breaking google tests