Skip to content

[Keyboard, Windows] Fix that IME events are still dispatched to FocusNode.onKey #104244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
May 21, 2022
Merged

[Keyboard, Windows] Fix that IME events are still dispatched to FocusNode.onKey #104244

fluttergithubbot merged 3 commits into from
May 21, 2022

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented May 20, 2022

Starting #77039, IME events on Windows are skipped. But they are only skipped for RawKeyboard.addListener, not FocusNode.onKey. This PR fixes it and adds tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 20, 2022
@dkwingsmt dkwingsmt requested a review from gspencergoog May 20, 2022 10:02
@dkwingsmt dkwingsmt mentioned this pull request May 20, 2022
Closed
gspencergoog
gspencergoog approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt added a: text input Entering text in a text field or keyboard related problems waiting for tree to go green platform-windows Building on or for Windows specifically a: desktop Running on desktop labels May 20, 2022
@fluttergithubbot fluttergithubbot merged commit baac9a8 into flutter:master May 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2022
@engine-flutter-autoroll
baac9a8 [Keyboard, Windows] Fix that IME events are still dispatched …
9b36027 
…to FocusNode.onKey (flutter/flutter#104244)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
baac9a8 [Keyboard, Windows] Fix that IME events are still dispatched …
838e931 
…to FocusNode.onKey (flutter/flutter#104244)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
baac9a8 [Keyboard, Windows] Fix that IME events are still dispatched …
ca6efae 
…to FocusNode.onKey (flutter/flutter#104244)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
baac9a8 [Keyboard, Windows] Fix that IME events are still dispatched …
9dd1bba 
…to FocusNode.onKey (flutter/flutter#104244)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@dkwingsmt @camsim99
[Keyboard, Windows] Fix that IME events are still dispatched to Focus…
54734db 
…Node.onKey (flutter#104244)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
baac9a8 [Keyboard, Windows] Fix that IME events are still dispatched …
618eacc 
…to FocusNode.onKey (flutter/flutter#104244)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
baac9a8 [Keyboard, Windows] Fix that IME events are still dispatched …
0cf6db6 
…to FocusNode.onKey (flutter/flutter#104244)
@wxw-9527 wxw-9527 mentioned this pull request Sep 23, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. platform-windows Building on or for Windows specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkwingsmt @gspencergoog @fluttergithubbot