Skip to content

add some exports of public API in foundation/serialization.dart #104231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jun 8, 2022
Merged

add some exports of public API in foundation/serialization.dart #104231

fluttergithubbot merged 1 commit into from
Jun 8, 2022

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented May 20, 2022 •
edited
Loading

Related to dart-lang/sdk#58731 this PR exports several types from dart:typed_data used in the public API of foundation/serialization.dart library.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels. labels May 20, 2022
@a14n a14n requested a review from Hixie May 20, 2022 07:58
@a14n a14n force-pushed the export-public-api branch from 4fcc81e to 9cbe7de Compare May 20, 2022 12:27
@a14n a14n requested a review from Piinks as a code owner May 20, 2022 12:27
@a14n a14n removed the request for review from Piinks May 20, 2022 12:27
@Hixie
Copy link
Contributor

Hixie commented May 25, 2022

This is exactly the kind of thing I was hoping we'd find.

@a14n
Copy link
Contributor Author

a14n commented May 25, 2022

If this PR is approved. How am I supposed to land it given the failure of the Linux flutter_plugins check?

@Hixie
Copy link
Contributor

Hixie commented May 26, 2022

If this PR is approved. How am I supposed to land it given the failure of the Linux flutter_plugins check?

We'll have to add a //ignore to that repo first.

Hixie
Hixie approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fyi @goderbauer

goderbauer
goderbauer approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice!

@a14n
Copy link
Contributor Author

a14n commented May 26, 2022

We'll have to add a //ignore to that repo first.

Could you help me to do that? I don't know which file need to be touch.
Moreover should I make this ignore change in the current Pr or another one?

@goderbauer
Copy link
Member

goderbauer commented May 26, 2022 •
edited
Loading

You have to add the ignores to the files/lines mentioned in the failing check in this repository in a separate PR: https://github.com/flutter/plugins.

@a14n
Copy link
Contributor Author

a14n commented May 26, 2022

ahhh ok. I thought you were asking to ignore this "Linux flutter_plugins" task in .ci.yaml or something like that. Thanks for the help :)

This was referenced May 26, 2022
Closed
Merged
Merged
@a14n a14n force-pushed the export-public-api branch from 9cbe7de to e8ae31c Compare May 30, 2022 07:20
@a14n a14n force-pushed the export-public-api branch 2 times, most recently from 66b073f to 42002ef Compare June 7, 2022 07:55
@a14n a14n mentioned this pull request Jun 7, 2022
Merged
@jmagman
Copy link
Member

jmagman commented Jun 7, 2022

flutter/plugins#5922 was picked up by the roll in #105523, once that merges you can rebase on/merge that.

@a14n a14n force-pushed the export-public-api branch 2 times, most recently from 0a72533 to 6627cdb Compare June 7, 2022 16:04
@a14n a14n mentioned this pull request Jun 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
04c0e5a 
…rt (flutter/flutter#104231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
3980b2d 
…rt (flutter/flutter#104231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
a7b7d27 
…rt (flutter/flutter#104231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
244a38f 
…rt (flutter/flutter#104231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
d3b82af 
…rt (flutter/flutter#104231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
2eb5f39 
…rt (flutter/flutter#104231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
c1b7125 
…rt (flutter/flutter#104231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
11390bb 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
dd9c435 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
8aa612e 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
d509141 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
b7e18f8 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
f465711 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
4afdf27 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
6f8daf7 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
62a3013 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
178c403 
…rt (flutter/flutter#104231)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@a14n @camsim99
add some exports of public API in foundation/serialization.dart (flut…
9df9c81 
…ter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
5917eb3 
…rt (flutter/flutter#104231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
56c4e3c add some exports of public API in foundation/serialization.da…
51d8d3f 
…rt (flutter/flutter#104231)
This was referenced Sep 1, 2022
Merged
Closed
@stuartmorgan-g stuartmorgan-g mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@a14n @Hixie @goderbauer @jmagman @fluttergithubbot