Removing Shorcuts.of and Shortctus.maybeOf #104215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
gspencergoog
changed the title
gspencergoog
force-pushed
the
remove_shortcut_manager_of
branch
from
682ba48 to
a20076a
Compare
goderbauer
approved these changes
May 19, 2022
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM if this doesn't break anything.
Member
There was a problem hiding this comment.
this field will stay null if the unnamed constructor is used, no?
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
gspencergoog
force-pushed
the
remove_shortcut_manager_of
branch
from
fb5282a to
dc3ec68
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
gspencergoog
force-pushed
the
remove_shortcut_manager_of
branch
2 times, most recently
from
4bcc200 to
5fe4526
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
gspencergoog
force-pushed
the
remove_shortcut_manager_of
branch
from
5fe4526 to
21ab1e0
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
gspencergoog
force-pushed
the
remove_shortcut_manager_of
branch
from
21ab1e0 to
2d22da9
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 25, 2022
CaseyHillers
added a commit
that referenced
this pull request
May 26, 2022
This reverts commit da24f10.
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Jun 1, 2022
This reverts commit da24f10.
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
This removes Shorcuts.of and Shortctus.maybeOf because they're not especially useful, since the only thing you can really set on a ShortcutManager is the shortcuts, and the Shortcuts widget that you give it to manages those, so if it rebuilds, it overwrites what you set. Also, adds a Shortcuts.manager constructor and removes the manager argument to the Shortcuts widget. Removing these will also eliminate an InheritedWidget for each Shortcuts widget, improving memory usage.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes
Shorcuts.ofandShortctus.maybeOfbecause they're not especially useful, since the only thing you can really set on aShortcutManageris the shortcuts, and theShortcutswidget that you give it to manages those, so if it rebuilds, it overwrites what you set.Also, adds a
Shortcuts.managerconstructor and removes themanagerargument to theShortcutswidget.Removing these will also eliminate an
InheritedWidgetfor eachShortcutswidget, improving memory usage.Tests
Shortcuts.manager.