Skip to content

Conversation

@xster
Copy link
Member

@xster xster commented May 31, 2017

No description provided.

@xster xster requested a review from cbracken May 31, 2017 21:59
@cbracken
Copy link
Member

lgtm

messages.add(new ValidationMessage.error(
'Xcode installation is incomplete; a full installation is necessary for iOS development.\n'
'Download at: https://developer.apple.com/xcode/download/\n'
'Or install Xcode via the App Store\n'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: period at the end of the sentence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

'Xcode installation is incomplete; a full installation is necessary for iOS development.\n'
'Download at: https://developer.apple.com/xcode/download/\n'
'Or install Xcode via the App Store\n'
'Once installed, run \'sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer\'.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're here, can you change this to:
'Once installed, run: "sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer"'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just formatted it like the rest of the file with an indent

@xster xster merged commit cb95972 into flutter:master Jun 2, 2017
@xster xster deleted the xcode-doc branch June 2, 2017 23:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants