Implement a pushRoute service to satisfy the FlutterView.pushRoute API #10415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @abarth to see if this is what he had in mind |
Contributor
|
this will need a test |
jason-simmons
force-pushed
the
push_route_method
branch
from
1873e73 to
a423110
Compare
jason-simmons
force-pushed
the
push_route_method
branch
from
a423110 to
0ef217a
Compare
Member
Author
|
Added a test to widgets/binding_test |
Contributor
|
This is great. It doesn't completely fix #10399 since there is no support on iOS yet. |
Contributor
|
Looks reasonable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10399