Skip to content

fixes 103234 to enable debugging Flutter apps on VR headset #104135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
May 21, 2022
Merged

fixes 103234 to enable debugging Flutter apps on VR headset #104135

fluttergithubbot merged 2 commits into from
May 21, 2022

Conversation

@csells
Copy link
Contributor

@csells csells commented May 19, 2022 •
edited
Loading

This PR updates how Android apps are launched by flutter_tool on a device via adb to explicitly specify both an action and a category, matching how Android Studio launches native Android apps and enabling flutter_tool to start Flutter apps on Quest VR headsets.

Issue fixed by this PR:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 19, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 19, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@csells csells mentioned this pull request May 19, 2022
Closed
@zanderso
Copy link
Member

zanderso commented May 19, 2022

The tests in this file need to be taught about the new arguments: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/android/android_device_start_test.dart

@csells
Copy link
Contributor Author

csells commented May 19, 2022

The tests in this file need to be taught about the new arguments: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/android/android_device_start_test.dart

Correct. Fixed!

@csells csells requested a review from christopherfujino May 19, 2022 19:39
@zanderso zanderso requested a review from blasten May 19, 2022 19:45
@csells csells requested a review from Jasguerrero May 19, 2022 20:00
blasten
blasten approved these changes May 21, 2022
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 4c66e30 into flutter:master May 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
4c66e30 fixes 103234 to enable debugging Flutter apps on VR headset (f…
d288787 
…lutter/flutter#104135)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2022
@engine-flutter-autoroll
4c66e30 fixes 103234 to enable debugging Flutter apps on VR headset (f…
458642d 
…lutter/flutter#104135)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
4c66e30 fixes 103234 to enable debugging Flutter apps on VR headset (f…
f87d89f 
…lutter/flutter#104135)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
4c66e30 fixes 103234 to enable debugging Flutter apps on VR headset (f…
08f1bfc 
…lutter/flutter#104135)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
4c66e30 fixes 103234 to enable debugging Flutter apps on VR headset (f…
8a3ca4d 
…lutter/flutter#104135)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@csells @camsim99
fixes 103234 to enable debugging Flutter apps on VR headset (flutter#…
b25a8d3 
…104135)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
4c66e30 fixes 103234 to enable debugging Flutter apps on VR headset (f…
50ccabd 
…lutter/flutter#104135)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
4c66e30 fixes 103234 to enable debugging Flutter apps on VR headset (f…
b9a4d04 
…lutter/flutter#104135)
@gnprice gnprice mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

@Jasguerrero Jasguerrero Awaiting requested review from Jasguerrero

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@csells @zanderso @blasten @fluttergithubbot