-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Reland "Fix Backbutton is not displayed when there is a endDrawer (#1… #104110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utter#102093)" This reverts commit a4a8e73.
dnfield
approved these changes
May 20, 2022
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
Not sure what is going with the google testing check, I couldn't find an entry in the dashboard, I did a manual submit it all tests passed cl/450486060 |
Contributor
Author
|
@CaseyHillers suggest manually merge if the test passed when running manually. See: cl/450486060 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 24, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
flutter#104110) * Reland "Fix Backbutton is not displayed when there is a endDrawer (flutter#102093)" This reverts commit a4a8e73. * add todos
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: material design
flutter/packages/flutter/material repository.
f: routes
Navigator, Router, and related APIs.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…02093)"
This reverts commit a4a8e73.
related #80256
This pr adds soft transition code in the second commit. Otherwise it is the same as previous pr
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.