Skip to content

Remove unneeded date comment in gradle-wrapper.properties #104061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Jun 13, 2022
Merged

Remove unneeded date comment in gradle-wrapper.properties #104061

fluttergithubbot merged 2 commits into from
Jun 13, 2022

Conversation

@asashour
Copy link
Contributor

@asashour asashour commented May 18, 2022

As the comment does not add any value.

Fixes #103616

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 18, 2022
@blasten
Copy link

blasten commented May 24, 2022

Thanks! there are a few more entries https://github.com/flutter/flutter/search?q=CEST+2018

@blasten blasten self-requested a review May 24, 2022 17:43
@asashour
Copy link
Contributor Author

asashour commented May 24, 2022

Thanks, done.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 24, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@blasten blasten requested a review from GaryQian May 24, 2022 20:28
@christopherfujino
Copy link
Contributor

christopherfujino commented Jun 9, 2022

CI is failing on your PR because there were problems upstream on master at the time you branched. If you rebase upstream, CI will re-run and checks should pass. Sorry about the trouble and thanks for contributing!

@fluttergithubbot fluttergithubbot merged commit 0be4a8e into flutter:master Jun 13, 2022
@asashour asashour deleted the 103616 branch June 14, 2022 05:05
This was referenced Jun 14, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
0be4a8e Remove unneeded date comment in gradle-wrapper.properties (f…
ab1d8b9 
…lutter/flutter#104061)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
0be4a8e Remove unneeded date comment in gradle-wrapper.properties (f…
12fd7d6 
…lutter/flutter#104061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
0be4a8e Remove unneeded date comment in gradle-wrapper.properties (f…
ee743ce 
…lutter/flutter#104061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
0be4a8e Remove unneeded date comment in gradle-wrapper.properties (f…
3c7900e 
…lutter/flutter#104061)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@asashour @camsim99
Remove unneeded date comment in gradle-wrapper.properties (flutter#…
84babb6 
…104061)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
0be4a8e Remove unneeded date comment in gradle-wrapper.properties (f…
24add83 
…lutter/flutter#104061)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
0be4a8e Remove unneeded date comment in gradle-wrapper.properties (f…
66111f6 
…lutter/flutter#104061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@blasten blasten blasten approved these changes

@GaryQian GaryQian GaryQian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unneeded date comment in gradle-wrapper.properties

5 participants

@asashour @blasten @fluttergithubbot @christopherfujino @GaryQian