Skip to content

Revert "Fix Backbutton is not displayed when there is a endDrawer" #104039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chunhtai merged 1 commit into from
May 18, 2022
Merged

Revert "Fix Backbutton is not displayed when there is a endDrawer" #104039

chunhtai merged 1 commit into from
May 18, 2022

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented May 18, 2022

Reverts #102093

This is breaking internal tests at Google (goldens need to be updated, and this seems to be a LSC)

@CaseyHillers CaseyHillers requested a review from chunhtai May 18, 2022 05:25
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. labels May 18, 2022
dnfield
dnfield approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chunhtai
chunhtai approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai merged commit a4a8e73 into master May 18, 2022
@chunhtai chunhtai deleted the revert-102093-issues/80256-reland branch May 18, 2022 16:53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2022
Merged
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 18, 2022
Revert "Fix Backbutton is not displayed when there is a endDrawer (fl…
c793244 
…utter#102093)" (flutter#104039)

This reverts commit f8f4387.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2022
@engine-flutter-autoroll
a4a8e73 Revert "Fix Backbutton is not displayed when there is a endDr…
7c9ab30 
…awer (#102093)" (flutter/flutter#104039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 18, 2022
@engine-flutter-autoroll
a4a8e73 Revert "Fix Backbutton is not displayed when there is a endDr…
bfd6f8d 
…awer (#102093)" (flutter/flutter#104039)
CaseyHillers pushed a commit that referenced this pull request May 18, 2022
Revert "Fix Backbutton is not displayed when there is a endDrawer (#1…
0ef3ece 
…02093)" (#104039) (#104096)

This reverts commit f8f4387.
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 19, 2022
Revert "Fix Backbutton is not displayed when there is a endDrawer (fl…
534c5b8 
…utter#102093)" (flutter#104039)

This reverts commit f8f4387.
CaseyHillers pushed a commit that referenced this pull request May 19, 2022
[flutter_releases] Framework CPs (#104214)
2ce4e22 
* Roll engine to e6c31a91

* Revert "Fix Backbutton is not displayed when there is a endDrawer (#102093)" (#104039)

This reverts commit f8f4387.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
a4a8e73 Revert "Fix Backbutton is not displayed when there is a endDr…
cf5a3a8 
…awer (#102093)" (flutter/flutter#104039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
a4a8e73 Revert "Fix Backbutton is not displayed when there is a endDr…
01e9c7f 
…awer (#102093)" (flutter/flutter#104039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaseyHillers @dnfield @chunhtai