Skip to content

Remove extraneous org.jetbrains.kotlin:kotlin-stdlib-jdk7 gradle dep #104028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
May 19, 2022
Merged

Remove extraneous org.jetbrains.kotlin:kotlin-stdlib-jdk7 gradle dep #104028

fluttergithubbot merged 3 commits into from
May 19, 2022

Conversation

@GaryQian
Copy link
Contributor

@GaryQian GaryQian commented May 18, 2022 •
edited
Loading

Fixes #101373 (comment)

Gradle plugin internally depends on the appropriate kotlin version, and our template version is out of date.

If we remove this completely, the app will just use the appropriate version selected by the gradle plugin.

Verified that apps build and run with no issues.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 18, 2022
@GaryQian GaryQian requested review from blasten and camsim99 May 18, 2022 00:29
@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 18, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 18, 2022

This pull request is not suitable for automatic merging in its current state.

@fluttergithubbot fluttergithubbot merged commit 350a761 into flutter:master May 19, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2022
@engine-flutter-autoroll
350a761 Remove extraneous org.jetbrains.kotlin:kotlin-stdlib-jdk7 gra…
2d6cf85 
…dle dep (flutter/flutter#104028)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 19, 2022
@engine-flutter-autoroll
350a761 Remove extraneous org.jetbrains.kotlin:kotlin-stdlib-jdk7 gra…
76d3601 
…dle dep (flutter/flutter#104028)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 19, 2022
@engine-flutter-autoroll
350a761 Remove extraneous org.jetbrains.kotlin:kotlin-stdlib-jdk7 gra…
f9b5a1b 
…dle dep (flutter/flutter#104028)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
350a761 Remove extraneous org.jetbrains.kotlin:kotlin-stdlib-jdk7 gra…
69a4f2a 
…dle dep (flutter/flutter#104028)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
350a761 Remove extraneous org.jetbrains.kotlin:kotlin-stdlib-jdk7 gra…
d38fedf 
…dle dep (flutter/flutter#104028)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
350a761 Remove extraneous org.jetbrains.kotlin:kotlin-stdlib-jdk7 gra…
7b85eb6 
…dle dep (flutter/flutter#104028)
@wujek-srujek wujek-srujek mentioned this pull request Dec 2, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camsim99 camsim99 Awaiting requested review from camsim99

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal]Incorrect kotlin-stdlib-jdk7 is added as a dependency for newly generated projects on Android

3 participants

@GaryQian @fluttergithubbot @blasten