Handle null values during yaml metadata parsing validation #104022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jmagman
commented
May 17, 2022
| expect(logger.traceText, contains('.metadata file at .metadata was empty or malformed.')); | ||
| }); | ||
|
|
||
| testWithoutContext('projectType is populated when version is null', () { |
Member
Author
There was a problem hiding this comment.
This test crashes with _CastError: Null check operator used on a null value on master.
| break; | ||
| } | ||
| if (map[entry.key] != null && (map[entry.key] as Object).runtimeType != entry.value) { | ||
| final Object? metadataValue = map[entry.key]; |
Member
Author
There was a problem hiding this comment.
This was the bug: when map[entry.key] was null, this method was returning true (valid).
Instead, check the map[entry.key] runtimeType even when it is null so it is marked as invalid and prints The value of key "x" in .metadata was expected to be y but was Null
| // Handled in _validate below. | ||
| } | ||
| if (yamlRoot == null || yamlRoot is! YamlMap) { | ||
| if (yamlRoot is! YamlMap) { |
Member
Author
There was a problem hiding this comment.
yamlRoot is! YamlMap will be true for null, no need to check both.
jmagman
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And other casting fixups.
Fixes #104021
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.