Reorder Theme fields and arguments to be consistently alphabetical within sections. #104011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
HansMuller
approved these changes
May 18, 2022
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM, although there's a trivial lint fix needed.
| /// * [ColorScheme.fromSeed], which is used to create a [ColorScheme] from a seed color. | ||
| factory ThemeData({ | ||
| // For the sanity of the reader, make sure these properties are in the same | ||
| // order everywhere that they are separated by section comments (e.g. |
Contributor
There was a problem hiding this comment.
order everywhere that they are => order everywhere and that they are
Contributor
Author
There was a problem hiding this comment.
Well, that's not what I meant, though: I meant that everywhere they are listed and (already) separated by section comments, they should be in the same order. I mean, yeah, they should also be separated by section comments everywhere that they're all listed too, but that's a different thing.
I'll change "everywhere" to be "in every place" if that helps.
Contributor
|
test-exempt: code refactor also, thank you so much for doing this |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 18, 2022
…tical within sections. (flutter/flutter#104011)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 18, 2022
…tical within sections. (flutter/flutter#104011)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 18, 2022
…tical within sections. (flutter/flutter#104011)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
…tical within sections. (flutter/flutter#104011)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
…tical within sections. (flutter/flutter#104011)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reorders Theme fields and arguments to be consistently alphabetical within sections by symbol name, for both the sanity of the reader, and the sanity of the person adding a new field.
Tests