-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Roll Flutter Engine from fce741dd83cf to 8ab17202937d (7 revisions) #103982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonahwilliams
merged 9 commits into
flutter:master
from
engine-flutter-autoroll:flutter-engine-flutter-autoroll-1e41432e-63d8-40d5-b3f8-09711dea0ab8-1652797709
May 17, 2022
Merged
Roll Flutter Engine from fce741dd83cf to 8ab17202937d (7 revisions) #103982
jonahwilliams
merged 9 commits into
flutter:master
from
engine-flutter-autoroll:flutter-engine-flutter-autoroll-1e41432e-63d8-40d5-b3f8-09711dea0ab8-1652797709
May 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
May 17, 2022
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
Mac_ios hot_mode_dev_cycle_macos_target__benchmark is stuck, stuck. I am going to manually land this so I don't need to keep patching in the binary change |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@fce741d...8ab1720
2022-05-17 [email protected] Roll Skia from 0a5146ca3ffd to 16fa353926b8 (28 revisions) (flutter/engine#33420)
2022-05-17 [email protected] Roll Dart SDK from 1bdb83bddf96 to 0bc104c3e959 (1 revision) (flutter/engine#33419)
2022-05-17 [email protected] Roll Fuchsia Mac SDK from t_ky8l6nb... to egBfZMmTP... (flutter/engine#33417)
2022-05-17 [email protected] Roll dart sdk to 1bdb83bddf96c41cc046810c697a2c80bfaaaf19 (flutter/engine#33416)
2022-05-17 [email protected] Roll Fuchsia Linux SDK from F0_B8WVKY... to IZ7_b83xC... (flutter/engine#33415)
2022-05-17 [email protected] Roll Dart SDK from 381855557df2 to f3bf9025c141 (1 revision) (flutter/engine#33411)
2022-05-17 [email protected] Set error handler (flutter/engine#33402)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from F0_B8WVKYgH_ to IZ7_b83xCnG0
fuchsia/sdk/core/mac-amd64 from t_ky8l6nbxY6 to egBfZMmTPuoU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md