Skip to content

[Slider]The initial value of discrete slider should respect the discrete values #103966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gspencergoog merged 1 commit into from
May 25, 2022
Merged

[Slider]The initial value of discrete slider should respect the discrete values #103966

gspencergoog merged 1 commit into from
May 25, 2022

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented May 17, 2022

Fixes #103965

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 17, 2022
@HansMuller HansMuller requested a review from gspencergoog May 20, 2022 21:58
gspencergoog
gspencergoog approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog gspencergoog merged commit 5a91967 into flutter:master May 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2022
@engine-flutter-autoroll
5a91967 [Slider]The initial value of discrete slider should respect t…
29d4aa0 
…he discrete values (flutter/flutter#103966)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
5a91967 [Slider]The initial value of discrete slider should respect t…
f41f672 
…he discrete values (flutter/flutter#103966)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
5a91967 [Slider]The initial value of discrete slider should respect t…
62b62b1 
…he discrete values (flutter/flutter#103966)
@guidezpl guidezpl mentioned this pull request May 26, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@xu-baolin @camsim99
[Slider]The initial value of discrete slider should respect the discr…
0d15311 
…ete values (flutter#103966)

Fixes flutter#103965
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5a91967 [Slider]The initial value of discrete slider should respect t…
d1077e7 
…he discrete values (flutter/flutter#103966)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5a91967 [Slider]The initial value of discrete slider should respect t…
270b37b 
…he discrete values (flutter/flutter#103966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Slider]The initial value of discrete slider does not respect the discrete values.

2 participants

@xu-baolin @gspencergoog