Skip to content

Delete flaky flutter_gallery XCUITest #103935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 18, 2022
Merged

Delete flaky flutter_gallery XCUITest #103935

fluttergithubbot merged 1 commit into from
May 18, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 16, 2022 •
edited
Loading

Re-land #103666 on #103727

Fixes #95193

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 16, 2022
@jmagman jmagman marked this pull request as ready for review May 16, 2022 23:03
@jmagman jmagman self-assigned this May 16, 2022
@jmagman jmagman requested a review from christopherfujino May 16, 2022 23:04
christopherfujino
christopherfujino approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@jmagman
Copy link
Member Author

jmagman commented May 16, 2022 •
edited
Loading

Verified native_ui_tests_ios are not being tested in the dashboard on top of #103727.
Screen Shot 2022-05-16 at 4 28 12 PM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 17, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 17, 2022

This pull request is not suitable for automatic merging in its current state.

@fluttergithubbot fluttergithubbot merged commit b90359d into flutter:master May 18, 2022
@jmagman jmagman deleted the gallery-delete-ui-test branch May 18, 2022 18:56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2022
@engine-flutter-autoroll
b90359d Delete flaky flutter_gallery XCUITest (flutter/flutter#103935)
c5524d0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 19, 2022
@engine-flutter-autoroll
b90359d Delete flaky flutter_gallery XCUITest (flutter/flutter#103935)
55bff12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 19, 2022
@engine-flutter-autoroll
b90359d Delete flaky flutter_gallery XCUITest (flutter/flutter#103935)
aa366fa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
b90359d Delete flaky flutter_gallery XCUITest (flutter/flutter#103935)
1fe4faa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b90359d Delete flaky flutter_gallery XCUITest (flutter/flutter#103935)
1a11513
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b90359d Delete flaky flutter_gallery XCUITest (flutter/flutter#103935)
be96d1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac_ios native_ui_tests_ios is 2.00% flaky, crash in XCUIApplicationMonitor

3 participants

@jmagman @fluttergithubbot @christopherfujino