Skip to content

[flutter_tools] throw error when argResults is null #103827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
May 17, 2022
Merged

[flutter_tools] throw error when argResults is null #103827

fluttergithubbot merged 5 commits into from
May 17, 2022

Conversation

@amanv8060
Copy link
Contributor

@amanv8060 amanv8060 commented May 14, 2022 •
edited
Loading

  • Replaces CommandDummy with the DummyFlutterCommand
  • throw an error when argResults is null

List which issues are fixed by this PR. You must list at least one issue.
part of #101595

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 14, 2022
@amanv8060
Copy link
Contributor Author

amanv8060 commented May 17, 2022

cc/ @Jasguerrero

christopherfujino
christopherfujino reviewed May 17, 2022
View reviewed changes
christopherfujino
christopherfujino reviewed May 17, 2022
View reviewed changes
christopherfujino
christopherfujino approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance, this looks right. I'll leave final approval for @Jasguerrero who knows this code better.

Jasguerrero
Jasguerrero approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 8fbf89b into flutter:master May 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2022
@engine-flutter-autoroll
8fbf89b [flutter_tools] throw error when argResults is null (flutter/…
84cf267 
…flutter#103827)
@amanv8060 amanv8060 deleted the throw_error branch May 17, 2022 19:57
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 18, 2022
@engine-flutter-autoroll
8fbf89b [flutter_tools] throw error when argResults is null (flutter/…
e2cb973 
…flutter#103827)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 18, 2022
@engine-flutter-autoroll
8fbf89b [flutter_tools] throw error when argResults is null (flutter/…
a27dfc7 
…flutter#103827)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
8fbf89b [flutter_tools] throw error when argResults is null (flutter/…
7ae7849 
…flutter#103827)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
8fbf89b [flutter_tools] throw error when argResults is null (flutter/…
3e26052 
…flutter#103827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amanv8060 @christopherfujino @Jasguerrero @fluttergithubbot