Skip to content

[ci] Add pointer to template image assets wiki #103787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbracken merged 1 commit into from
May 14, 2022
Merged

[ci] Add pointer to template image assets wiki #103787

cbracken merged 1 commit into from
May 14, 2022

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 14, 2022

Many of our flutter_tools templates include image assets such as
application icons. Adding these will trigger an analysis error from our
CI tooling.

This adds a pointer to the wiki describing the procedure for adding or
updating image assets in the templates:
https://github.com/flutter/flutter/wiki/Managing-template-image-assets

Uncovered while working on #103371

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[ci] Add pointer to template image assets wiki
baead63 
Many of our flutter_tools templates include image assets such as
application icons. Adding these will trigger an analysis error from our
CI tooling.

This adds a pointer to the wiki describing the procedure for adding or
updating image assets in the templates:
https://github.com/flutter/flutter/wiki/Managing-template-image-assets

Uncovered while working on flutter#103371
@cbracken cbracken added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. documentation labels May 14, 2022
@cbracken cbracken requested review from Hixie and stuartmorgan-g May 14, 2022 05:13
@cbracken cbracken merged commit 110c0a7 into flutter:master May 14, 2022
@cbracken cbracken deleted the update-binaries-message branch May 14, 2022 17:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
99f9a6f 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
f8deb98 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
300d80d 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
2eb6b9e 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
1696426 
…er#103787)
@cbracken cbracken mentioned this pull request May 15, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
9504a9f 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
ac5abed 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
75f07fb 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
b7d09e1 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
9c5f634 
…er#103787)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
f860993 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
346d8b9 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
47c4207 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
85528cd 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
40124ca 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
dfa8cb0 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
8a59b78 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
b6d1297 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
151b383 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
85acb85 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
5e16811 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
0b9166e 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
fd4656f 
…er#103787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
ede290a 
…er#103787)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
d1fcd78 
…er#103787)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
110c0a7 [ci] Add pointer to template image assets wiki (flutter/flutt…
2ebf1cd 
…er#103787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbracken @stuartmorgan-g