Skip to content

[tool] Fix BuildInfo.packagesPath doc comment #103785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbracken merged 1 commit into from
May 14, 2022
Merged

[tool] Fix BuildInfo.packagesPath doc comment #103785

cbracken merged 1 commit into from
May 14, 2022

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 14, 2022

Until recently, BuildInfo.packagesPath defaulted to .packages however,
the .packages file has been deprecated [1] and is being removed. In
#99677 the default was changed to
.dart_tool/package_config.json but the doc comment was accidentally
updated to .dart_tool/packages. This corrects it to the true default
value.

1: dart-lang/sdk#48272

Spotted in the midst of some related cleanup relating to
#103775

No tests modified since no semantic change is involved to the code.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[tool] Fix BuildInfo.packagesPath doc comment
fe83acc 
Until recently, BuildInfo.packagesPath defaulted to `.packages` however,
the .packages file has been deprecated [1] and is being removed. In
flutter#99677 the default was changed to
`.dart_tool/package_config.json` but the doc comment was accidentally
updated to `.dart_tool/packages`. This corrects it to the true default
value.

1: dart-lang/sdk#48272

Spotted in the midst of some related cleanup relating to
flutter#103775
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 14, 2022
stuartmorgan-g
stuartmorgan-g approved these changes May 14, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken merged commit f2116cb into flutter:master May 14, 2022
@cbracken cbracken deleted the fix-doc-comment branch May 14, 2022 17:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
3d7dc5b 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
9289215 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
4754936 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
8749629 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
d664c4c 
…r#103785)
@cbracken cbracken mentioned this pull request May 15, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
cc2f2ed 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
18900dc 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
34aa10e 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
81ea9df 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
e00e587 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
b328b9a 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
845997f 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
03371f6 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
f33a5ec 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
f8e0ff0 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
21f1114 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
592a70e 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
0484ea5 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
3bd7927 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
2911ef9 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
db427e7 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
1b1ce9a 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
84f3190 
…r#103785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
1397231 
…r#103785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
1bb145e 
…r#103785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
f2116cb [tool] Fix BuildInfo.packagesPath doc comment (flutter/flutte…
239545f 
…r#103785)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

@sigurdm sigurdm Awaiting requested review from sigurdm

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbracken @stuartmorgan-g