Skip to content

Fix deprecation doc comment #103776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbracken merged 1 commit into from
May 14, 2022
Merged

Fix deprecation doc comment #103776

cbracken merged 1 commit into from
May 14, 2022

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 14, 2022 •
edited
Loading

Point users of boolArgDeprecated to boolArg rather than to
boolArgDeprecated in order to avoid losing them to infinite loops or
stack overflows depending on their implementation.

Spotted during tangentially-related cleanup for
#103371

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Fix deprecation doc comment
81a98a7 
Point users of boolArgDeprecated to boolArg rather than to
boolArgDeprecated in order to avoid losing users to infinite loops or
stack overflows depending on their implementation.
@cbracken cbracken added tool Affects the "flutter" command-line tool. See also t: labels. documentation labels May 14, 2022
@cbracken cbracken merged commit 28aaa1e into flutter:master May 14, 2022
@cbracken cbracken deleted the doc-fix branch May 14, 2022 02:23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
5b9136e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
b532885
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
3370be8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
10fcbd5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
c1765cb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
566c75b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
f295544
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
b42c943
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
4e8edd0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
b0fb0df
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
3f00213
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
1b8b7c6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
bcf237a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
5b0de56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
4934900
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
ab3c432
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
781efd3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
6ebc4b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
8b82bf4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
9dc904a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
5c1e234
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
2454383
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
22cb93e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
bc1204f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
340a890
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
dd1581b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
28aaa1e Fix deprecation doc comment (flutter/flutter#103776)
2680a37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @christopherfujino @stuartmorgan-g