[flutter_tools] ensure linux doctor validator finishes when pkg-config is not installed #103755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
zanderso
approved these changes
May 13, 2022
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 14, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 14, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 14, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 14, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 14, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 14, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 14, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 15, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 15, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 15, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 15, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 15, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 16, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 16, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 16, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 16, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 16, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 16, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 16, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 16, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 17, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
…kg-config is not installed (flutter/flutter#103755)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
…kg-config is not installed (flutter/flutter#103755)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up fix to #100159
Even though we were catching the initial exception when we called
pkg-config --version, we then followed to callpkg-configagain to look up gtk libraries, so the exception bubbled up again into the doctor. Instead, only validate the gtk libraries if we know pkg-config is installed.Fixes #103744