Skip to content

Make _RenderCustomClip respect clipBehavior #103748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 14, 2022
Merged

Make _RenderCustomClip respect clipBehavior #103748

fluttergithubbot merged 1 commit into from
May 14, 2022

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented May 13, 2022

Today _RenderCustomClip unconditionally (and unconscionably) claims to clip its children, even if its clipBehavior == Clip.none (in which case it does not actually apply a clip to the canvas or the layer stack).

This fixes that and adds a test.

Part of making the visibility_detector refactor work.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 13, 2022
jonahwilliams
jonahwilliams approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goderbauer
goderbauer approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor Author

dnfield commented May 13, 2022

Oh man finally one of these is passing tests.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 13, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield
Copy link
Contributor Author

dnfield commented May 13, 2022

Internal failures are minor scuba changes.

@dnfield
Copy link
Contributor Author

dnfield commented May 13, 2022

I'm going to manually mark this as ok and will file a g3fix for the scubas later.

@fluttergithubbot fluttergithubbot merged commit 4f96419 into flutter:master May 14, 2022
@dnfield dnfield deleted the clip branch May 14, 2022 00:15
@dnfield dnfield mentioned this pull request May 14, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
8da8057 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
059ad78 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
2308557 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
644ada0 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
6ead11a 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
ce91692 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
dc42687 
…103748)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
15d89f5 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
3451bac 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
a056391 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
84de5ca 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
44f76bf 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
324a552 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
d88b5b4 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
1b010d8 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
d13e069 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
17f808d 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
d357972 
…103748)
@dnfield dnfield mentioned this pull request May 16, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
a2ca88e 
…103748)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
9fdfe06 
…103748)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
fc56330 
…103748)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
4f96419 Make _RenderCustomClip respect clipBehavior (flutter/flutter#…
d38f338 
…103748)
@hannah-hyj hannah-hyj mentioned this pull request Sep 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @fluttergithubbot @goderbauer @jonahwilliams