Skip to content

Fix avoid_redundant_argument_values analyzer warnings enabled in the latest Dart SDK #103734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
May 13, 2022
Merged

Fix avoid_redundant_argument_values analyzer warnings enabled in the latest Dart SDK #103734

zanderso merged 1 commit into from
May 13, 2022

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented May 13, 2022

See #103719

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 13, 2022
jonahwilliams
jonahwilliams approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member

zanderso commented May 13, 2022

FRoB testing seems to be having some issues. Landing manually to unblock the engine roll.

@zanderso zanderso merged commit 275fb02 into flutter:master May 13, 2022
This was referenced May 13, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
11ebe46 
… in the latest Dart SDK (flutter/flutter#103734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
5d262f2 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
095ab55 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
5391dac 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
77d9b10 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
3d18cc0 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
05f8435 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
c169b57 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
512f395 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
8a8ed70 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
9e17187 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
9093f64 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
8d27115 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
b3f30b6 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
48c3cf7 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
fdb3f2b 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
e022e86 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
4dae8e5 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
6e2434f 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
e4986c3 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
2c6a5eb 
… in the latest Dart SDK (flutter/flutter#103734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
d66864f 
… in the latest Dart SDK (flutter/flutter#103734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
c9c6189 
… in the latest Dart SDK (flutter/flutter#103734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
8df662a 
… in the latest Dart SDK (flutter/flutter#103734)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
275fb02 Fix avoid_redundant_argument_values analyzer warnings enabled…
830a24e 
… in the latest Dart SDK (flutter/flutter#103734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jason-simmons @zanderso @jonahwilliams