Skip to content

[flutter_tools] remove assertion for deprecation .packages #103729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
May 13, 2022
Merged

[flutter_tools] remove assertion for deprecation .packages #103729

zanderso merged 1 commit into from
May 13, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented May 13, 2022

.packages is deprecated and not used by the tool. Unblocks the pub roll.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 13, 2022
christopherfujino
christopherfujino approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member

zanderso commented May 13, 2022

This can't affect the internal roll. Landing manually to unblock the engine roll.

@zanderso zanderso merged commit 7384644 into flutter:master May 13, 2022
@jonahwilliams jonahwilliams deleted the remove-packages-validation branch May 13, 2022 20:00
This was referenced May 13, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
9be6647 
…lutter/flutter#103729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
3a4423f 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
6f86df9 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
f7d43ff 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
52c0754 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
f47f02d 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
b51a268 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
afc12e2 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
07114fa 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
82f9874 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
4c5fed6 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
2819bfe 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
dfbd18c 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
c78ab5c 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
cf4d5ee 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
9ff57ef 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
d4c8235 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
dc2377b 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
36a26e9 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
f2c2c0d 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
1bdde11 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
777eceb 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
c8276eb 
…lutter/flutter#103729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
51f665d 
…lutter/flutter#103729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
473c19e 
…lutter/flutter#103729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
7384644 [flutter_tools] remove assertion for deprecation .packages (f…
da3d035 
…lutter/flutter#103729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @zanderso @christopherfujino