Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 13, 2022

Should have been included in #103666.

First part of #95193

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@christopherfujino
Copy link
Contributor

Won't this still be red until the ci_yaml roller finishes?

@jmagman
Copy link
Member Author

jmagman commented May 13, 2022

#103666 was reverted with #103726, this should merge first.

@jmagman jmagman requested a review from christopherfujino May 13, 2022 17:43
@christopherfujino
Copy link
Contributor

To follow-up from discord discussion, I landed my revert instead and this deprecation will be re-landed in two PRs; the first removing the builders, the second deleting the test code

@keyonghan
Copy link
Contributor

@christopherfujino I believe this is safe to land. Any concern here to close this PR?

@jmagman jmagman reopened this May 13, 2022
@christopherfujino
Copy link
Contributor

Oops, sorry, yeah, we should land this

@jmagman
Copy link
Member Author

jmagman commented May 13, 2022

I landed my revert instead and this deprecation will be re-landed in two PRs; the first removing the builders

This would be the first PR then.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants