-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Delete native_ui_tests_ios #103727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete native_ui_tests_ios #103727
Conversation
|
Won't this still be red until the ci_yaml roller finishes? |
|
To follow-up from discord discussion, I landed my revert instead and this deprecation will be re-landed in two PRs; the first removing the builders, the second deleting the test code |
|
@christopherfujino I believe this is safe to land. Any concern here to close this PR? |
|
Oops, sorry, yeah, we should land this |
This would be the first PR then. |
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request is not suitable for automatic merging in its current state.
|
|
This pull request is not suitable for automatic merging in its current state.
|
Should have been included in #103666.
First part of #95193
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.