Skip to content

Revert "Delete flaky flutter_gallery XCUITest" #103726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopherfujino merged 1 commit into from
May 13, 2022
Merged

Revert "Delete flaky flutter_gallery XCUITest" #103726

christopherfujino merged 1 commit into from
May 13, 2022

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented May 13, 2022

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 13, 2022
@christopherfujino
Copy link
Contributor Author

christopherfujino commented May 13, 2022

Landing this TBR @jmagman or @justinmc as this is at the tip of the tree and to green the tree

@christopherfujino
Copy link
Contributor Author

christopherfujino commented May 13, 2022

Oh, I guess I can't land it TBR

@jmagman
Copy link
Member

jmagman commented May 13, 2022

Would prefer to fix forward #103727

jmagman
jmagman approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino merged commit 708c363 into master May 13, 2022
@christopherfujino christopherfujino deleted the revert-103666-gallery-delete-ui-test branch May 13, 2022 17:42
This was referenced May 13, 2022
Merged
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
78b8bdf 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
a519aa6 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
d3ed1e8 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
23aaa12 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
d0b38dc 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
f2018c1 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
23f28fb 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
ad689f5 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
edbd022 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
1d29837 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
74bf61a 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
b08eb95 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
f4989f6 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
b1040fe 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
33e0a51 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
1b8c156 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
5d79d2e 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
894f3ba 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
49db379 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
df2f513 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
6dfe29b 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
64e68d9 
…tter/flutter#103726)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
c596622 
…tter/flutter#103726)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
69235fd 
…tter/flutter#103726)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
0057ad2 
…tter/flutter#103726)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
708c363 Revert "Delete flaky flutter_gallery XCUITest (#103666)" (flu…
7bbc7f5 
…tter/flutter#103726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherfujino @jmagman