Skip to content

Define ColorSwatch.lerp() function #103701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
May 19, 2022
Merged

Define ColorSwatch.lerp() function #103701

fluttergithubbot merged 4 commits into from
May 19, 2022

Conversation

@davidmigloz
Copy link
Contributor

@davidmigloz davidmigloz commented May 13, 2022 •
edited by gspencergoog
Loading

Add lerp() function to ColorSwatch

Fixes #103695

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 13, 2022
@davidmigloz davidmigloz mentioned this pull request May 13, 2022
Closed
@davidmigloz davidmigloz force-pushed the color-swatch-lerp branch 2 times, most recently from a4ec839 to 96bc3f2 Compare May 13, 2022 13:04
@HansMuller HansMuller requested a review from gspencergoog May 13, 2022 21:48
gspencergoog
gspencergoog requested changes May 18, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Flutter repo, we don't use dart format for formatting, and readability is favored over staying within 80 characters.

https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#prefer-a-maximum-line-length-of-80-characters

@davidmigloz
Copy link
Contributor Author

davidmigloz commented May 18, 2022

Thanks for the review @gspencergoog. Good to know that you are not strict with the 80 characters' limit. I've committed your suggestions. Let me know if it looks good now.

@goderbauer goderbauer requested a review from gspencergoog May 18, 2022 21:43
gspencergoog
gspencergoog approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

(But please fix the variable naming issue.)

@gspencergoog gspencergoog changed the title Define ColorSwatch.lerp() function (#103695) Define ColorSwatch.lerp() function May 18, 2022
@gspencergoog gspencergoog changed the title Define ColorSwatch.lerp() function Define ColorSwatch.lerp() function May 18, 2022
justinmc
justinmc approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a docs nit.

@davidmigloz
Copy link
Contributor Author

davidmigloz commented May 19, 2022

fixed! 🙂

@fluttergithubbot fluttergithubbot merged commit b1f10ce into flutter:master May 19, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2022
@engine-flutter-autoroll
b1f10ce Define ColorSwatch.lerp() function (flutter/flutter#103701)
974bbc8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
b1f10ce Define ColorSwatch.lerp() function (flutter/flutter#103701)
279027d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b1f10ce Define ColorSwatch.lerp() function (flutter/flutter#103701)
179cd86
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b1f10ce Define ColorSwatch.lerp() function (flutter/flutter#103701)
0c03db5
@davidmigloz davidmigloz deleted the color-swatch-lerp branch April 11, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define ColorSwatch.lerp() function

4 participants

@davidmigloz @justinmc @gspencergoog @fluttergithubbot