Skip to content

[flutter_tools] fix test asset loading #103667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 6 commits into from
May 14, 2022
Merged

[flutter_tools] fix test asset loading #103667

fluttergithubbot merged 6 commits into from
May 14, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented May 12, 2022 •
edited
Loading

Ensure that flutter_tester has the asset directory so that it can load test assets, fix automated test that was indented wrong.

Part of #103724

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 12, 2022
@jonahwilliams jonahwilliams requested a review from dnfield May 12, 2022 23:55
@jonahwilliams jonahwilliams changed the title [flutter_tools] fix test asset loading [flutter_tools] fix test asset loading [DO NOT LAND] May 13, 2022
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. labels May 13, 2022
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented May 13, 2022

Actually this will impact g3, holding off for now

@jonahwilliams jonahwilliams changed the title [flutter_tools] fix test asset loading [DO NOT LAND] [flutter_tools] fix test asset loading May 13, 2022
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented May 13, 2022

Updated this change so that we can have the google3 tester pass in the correct asset path and fix test asset loading

@jonahwilliams jonahwilliams mentioned this pull request May 13, 2022
Closed
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented May 14, 2022

Now that flutter/engine#33323 has rolled in this should be safe to reland.

jonahwilliams
jonahwilliams commented May 14, 2022
View reviewed changes
packages/flutter_tools/lib/src/test/flutter_tester_device.dart
'--enable-dart-profiling',
'--non-interactive',
'--use-test-fonts',
'--disable-asset-fonts',
Copy link
Contributor Author

@jonahwilliams jonahwilliams May 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new flag that prevents the tester from registering fonts bundled in the asset directory. It allows us to load other assets as normal while keeping the same font behavior

@jonahwilliams jonahwilliams mentioned this pull request May 14, 2022
Merged
@jonahwilliams jonahwilliams requested a review from dnfield May 14, 2022 17:00
@fluttergithubbot fluttergithubbot merged commit 90a592b into flutter:master May 14, 2022
@jonahwilliams jonahwilliams deleted the fix_asset_load_test branch May 14, 2022 18:08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
6887bf8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
2c3383b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
fc53b61
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
ff080fb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
70605c9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
c06bfd5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
33061ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
bd40097
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
160d87e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
7be8a0e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
e0091d8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
60449cf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
99dc7cd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
d05e2f8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
e875a75
@jonahwilliams jonahwilliams mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
1aa1726
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
90a592b [flutter_tools] fix test asset loading (flutter/flutter#103667)
dedf146
@renancaraujo renancaraujo mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @dnfield @fluttergithubbot